Uh oh!
There was an error while loading. Please reload this page.
Conversation
PaulWessel
approved these changes
Aug 20, 2020
seisman added a commit
that referenced
this pull request
Aug 20, 2020
PaulWessel added a commit
that referenced
this pull request
Sep 22, 2021
As a way to debug and implement subsets of images, I am letting grdcut -I get the ability to cut a subset out of an image. This also makes it easier to debug this feature which is still not working in GMT (and affects grdimage, for instance, where the entire image must be read in). Derives bits and pieces from stalled PR #4004.
PaulWessel added a commit
that referenced
this pull request
Sep 28, 2021
* WIP Let grdcut -I operate on images As a way to debug and implement subsets of images, I am letting grdcut -I get the ability to cut a subset out of an image. This also makes it easier to debug this feature which is still not working in GMT (and affects grdimage, for instance, where the entire image must be read in). Derives bits and pieces from stalled PR #4004. * Handle i->colormap as columns * Update gmt_gdalread.c * set no pad * Finalize * Remove -I and let grdcut figure out if it is an image instead * Make sure we update "grid" type after reading image * Implement west/west reading if straddling boundary * Allow -S -F as well for images * Update grdcut.c * Update grdcut.c * Better comments and add gmt_gdalread: to print statements * Fix depadding in gmt_gdalwrite * Update gmt_support.c * Also unpack colors for pattern fills * Want no subset of image here * Update grdimage.c * Finalize metadata explorer * Improve BC handling for images * BC stuff * Use the data BC for images * A few more things * Update grdimage.c * Update gmt_support.c * Update gmt_gdalwrite.c Minor initializations etc * Update grdcut.c Needed to turn on data padding in grdcut. * Fix bad rounding Better use irint to get nearest integer than rely on adding noise and cast to int. * Update 3 PS files * Update gmt_gdalread.c * Better determination of tiff images Add to gmt_raster_type since also needed in grdcut. * Add extra test Test based on Federico's Caribbean case plus a similar one straddling 180. Passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the CI step to cache GMT remote files. It should fixes the weird failures in #3982.