Uh oh!
There was an error while loading. Please reload this page.
Fix the expected result in test/api/apiputvector.sh - #8615
Merged
Conversation
joa-quim
approved these changes
Nov 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test
test/api/apiputvector.shchecks the output of the test program https://github.com/GenericMappingTools/gmt/blob/master/src/testapi_putvector.c.As you can see in the C file, the first column the program passes is 134.9 and 202. So we also expect to see 134.9 and 202 as the first column in the output. However, the
answer.txtfile holds the incorrect answer due to a GMT bug.The bug was fixed recently in #8600. That's why the test starts to fail recently. This PR fixes the
answer.txtfile and now the test passes again.