Uh oh!
There was an error while loading. Please reload this page.
gmtest: don't require execute permission on test scripts - #9135
Merged
Conversation
Test scripts are sourced (". ${local_script}"), not executed, so the
existing "if ! [ -x "${script}" ]" guard was checking the wrong bit.
It started failing every test once #9133 removed the unnecessary
executable permission from *.sh scripts. Relax the guard to check
readability instead.
Note: switching the sourcing itself (". ${local_script}") to
"bash ${local_script}" was also proposed, but that would run the test
script in a subshell instead of gmtest.sh's own shell, breaking the
"ps=" variable classic-mode scripts set for later baseline comparison
(it wouldn't propagate back). Sourcing is kept as-is since it never
required execute permission in the first place.
Related to #9048, #9133
Assisted-by: Claude Sonnet 5 (High effort)Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #9133. Removing the executable bit from test/example scripts made every test fail, because
test/gmtest.inexplicitly checked for it:Test scripts are sourced (
. "${local_script}"), not executed, so this check was never actually needed — it only requires read permission. Relaxed it to-r.@seisman also suggested changing the sourcing itself to
bash "${local_script}". I kept.(source) instead: switching tobashruns the script in a subshell, so a classic-mode script'sps=...variable (used afterwards for the baseline image comparison) would no longer propagate back intogmtest.sh, breaking every classic-mode test.Closes#9048
Assisted-by: Claude Sonnet 5 (High effort)