Skip to content

Tiny fixes for the plot tutorial - #1026

Merged
seisman merged 8 commits into
GenericMappingTools:masterfrom
core-man:tutorial-plot
Mar 10, 2021
Merged

Tiny fixes for the plot tutorial#1026
seisman merged 8 commits into
GenericMappingTools:masterfrom
core-man:tutorial-plot

Conversation

@core-man

Copy link
Copy Markdown
Member

Description of proposed changes

See https://en.wikipedia.org/wiki/Hypocenter:

A hypocenter (or hypocentre) is the point of origin of an earthquake or a subsurface nuclear explosion.

"the locations of the hypocenters of the earthquakes" seems a little repeated because hypocenter is actually the location of an earthquake. So it's better to remove "of the hypocenters".

Related to #983 and #996.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@core-mancore-man changed the title Tiny fix for the/plot tutorialTiny fix for the plot tutorialMar 9, 2021
@seismanseisman added the documentation Improvements or additions to documentation label Mar 9, 2021
@seismanseisman added this to the 0.3.1 milestone Mar 9, 2021
Comment threadexamples/tutorials/plot.py Outdated
@core-man

Copy link
Copy Markdown
MemberAuthor

/format

@seisman

Copy link
Copy Markdown
Member

Could you also change argument to parameter in this tutorial, as discussed in #886.

@seisman
seisman marked this pull request as draft March 9, 2021 19:12
@core-man

Copy link
Copy Markdown
MemberAuthor

Could you also change argument to parameter in this tutorial, as discussed in #886.

Done in fb76425.

@seisman

Copy link
Copy Markdown
Member

Line 64: Change "the color" to "the color parameter".

@seismanseisman added the skip-changelog Skip adding Pull Request to changelog label Mar 10, 2021
@core-man

Copy link
Copy Markdown
MemberAuthor

Line 64: Change "the color" to "the color parameter".

done in 552aa5c.

@seisman
seisman marked this pull request as ready for review March 10, 2021 06:38
@seismanseisman changed the title Tiny fix for the plot tutorialTiny fixes for the plot tutorialMar 10, 2021
@seisman
seisman merged commit 6691f77 into GenericMappingTools:masterMar 10, 2021
@core-man
core-man deleted the tutorial-plot branch March 12, 2021 14:47
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationskip-changelogSkip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@core-man@seisman@maxrjones@michaelgrund