Skip to content

Refactor text to use virtualfile_from_data - #1121

Merged
seisman merged 14 commits into
mainfrom
refactor-text
May 22, 2022
Merged

Refactor text to use virtualfile_from_data#1121
seisman merged 14 commits into
mainfrom
refactor-text

Conversation

@seisman

@seismanseisman commented Mar 25, 2021•
edited
Loading

Copy link
Copy Markdown
Member

Description of proposed changes

  • Refactor text to use virtualfile_from_data
  • Raise exceptions for invalid inputs
  • Add more tests for invalid inputs

Related to #949.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seismanseisman changed the title WIP: Refactor text to use virtual_from_dataRefactor text to use virtual_from_dataMar 25, 2021
@seisman
seisman marked this pull request as ready for review March 25, 2021 06:39
@seismanseisman changed the title Refactor text to use virtual_from_dataRefactor text to use virtualfile_from_dataMar 25, 2021
@seismanseisman added the maintenance Boring but important stuff for the core devs label Mar 26, 2021
@seismanseisman added this to the 0.4.0 milestone Mar 26, 2021
@seismanseisman self-assigned this Mar 26, 2021
@seismanseisman mentioned this pull request Apr 5, 2021
Merged
5 tasks
maxrjones
maxrjones approved these changes Apr 15, 2021
View reviewed changes

@maxrjonesmaxrjones left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I only had a couple small comments.

Comment threadpygmt/src/text.py Outdated
kwargs["t"] = ""

# Append text as the last column
# text must be in str type, see issue #706

@maxrjonesmaxrjonesApr 14, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed now, correct?

Suggested change
# text must be in str type, see issue #706

@seismanseismanMay 14, 2022

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

text must be in str type

This statement is still True.

Comment threadpygmt/src/text.py
Comment threadpygmt/src/text.py Outdated
core-man
core-man reviewed Apr 15, 2021
View reviewed changes
Comment threadpygmt/tests/test_text.py
@seisman

seisman commented Apr 15, 2021

Copy link
Copy Markdown
MemberAuthor

Thanks for your suggestions. I'll mark this PR as draft, because I don't like the current implemention.

@seisman
seisman marked this pull request as draft April 15, 2021 14:52
@maxrjones
maxrjones self-requested a review April 15, 2021 14:54
@core-mancore-man mentioned this pull request May 20, 2021
Merged
5 tasks
@weiji14weiji14 mentioned this pull request Jun 1, 2021
Closed
6 tasks
@weiji14weiji14 modified the milestones: 0.4.0, 0.5.0Jun 18, 2021
@weiji14weiji14 mentioned this pull request Jul 23, 2021
Open
@weiji14weiji14 mentioned this pull request Sep 1, 2021
Closed
@weiji14weiji14 removed this from the 0.5.0 milestone Sep 30, 2021
@seismanseisman added this to the 0.7.0 milestone Mar 18, 2022
seisman
seisman commented May 14, 2022
View reviewed changes
Comment threadpygmt/src/text.py Outdated
seismanand others added 2 commits May 14, 2022 18:10
@seismanMax Jones
Apply suggestions from code review
4b3d92a
Co-authored-by: Max Jones <meghanj@alum.mit.edu>
@seisman
Fix formatting issues
cb6bf1e
@seisman
seisman marked this pull request as ready for review May 14, 2022 10:33
weiji14
weiji14 reviewed May 16, 2022
View reviewed changes

@weiji14weiji14 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a quick glance and can't see any major issues with this refactor. Is there anything else remaining you want to work on here @seisman?

Comment threadpygmt/src/text.py Outdated
Comment threadpygmt/src/text.py Outdated
@seisman

seisman commented May 16, 2022

Copy link
Copy Markdown
MemberAuthor

Is there anything else remaining you want to work on here?

I plan to not make more reactors in this PR to make it easier to review.

weiji14
weiji14 reviewed May 16, 2022
View reviewed changes

@weiji14weiji14 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me. Sugest @meghanrjones (or someone else) to give this another review since it's been over a year since they approved this PR!

@weiji14weiji14 added the final review call This PR requires final review and approval from a second reviewer label May 16, 2022
@seisman@weiji14
Apply suggestions from code review
5768d50
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
@seisman

seisman commented May 19, 2022

Copy link
Copy Markdown
MemberAuthor

Ping @meghanrjones to give this PR a final review.

@seismanseisman removed the final review call This PR requires final review and approval from a second reviewer label May 22, 2022
@seisman
seisman merged commit ed591a3 into mainMay 22, 2022
@seisman
seisman deleted the refactor-text branch May 22, 2022 06:25
@maxrjones

maxrjones commented May 22, 2022

Copy link
Copy Markdown
Member

Sorry for not getting back to this in time to be helpful

@seisman

seisman commented May 22, 2022

Copy link
Copy Markdown
MemberAuthor

No worries. You can still leave your comments if there are any 😄

sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@seismanMax Jones
@weiji14Josh Sixsmith
Refactor text to use virtualfile_from_data (GenericMappingTools#1121)
b1b408f
Co-authored-by: Max Jones <meghanj@alum.mit.edu>
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weiji14weiji14weiji14 left review comments
@core-mancore-mancore-man left review comments
@maxrjonesmaxrjonesAwaiting requested review from maxrjones

Assignees

@seismanseisman

Labels

maintenanceBoring but important stuff for the core devs

Projects

None yet

Milestone

0.7.0

Development

Successfully merging this pull request may close these issues.

4 participants

@seisman@maxrjones@weiji14@core-man