Skip to content

Update fig.solar baseline images for GMT 6.2.0rc1 - #1232

Merged
weiji14 merged 5 commits into
masterfrom
gmt-6.2.0rc1/solar
Apr 30, 2021
Merged

Update fig.solar baseline images for GMT 6.2.0rc1#1232
weiji14 merged 5 commits into
masterfrom
gmt-6.2.0rc1/solar

Conversation

@seisman

Copy link
Copy Markdown
Member

Description of proposed changes

Address #1217

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seismanseisman added this to the 0.4.0 milestone Apr 22, 2021
@seismanseisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Apr 22, 2021
@github-actions

github-actionsBot commented Apr 22, 2021

Copy link
Copy Markdown
Contributor

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

StatusPath
modifiedpygmt/tests/baseline/test_solar_set_terminator_datetime.png
modifiedpygmt/tests/baseline/test_solar_terminators.png

Image diff(s)

Details

Added images

Modified images

PathOldNew
test_solar_set_terminator_datetime.png
test_solar_terminators.png

Report last updated at commit 0b9544c

@seismanseisman mentioned this pull request Apr 22, 2021
3 tasks
@weiji14

weiji14 commented Apr 22, 2021

Copy link
Copy Markdown
Member

Four tests are still failing, off by a few pixels https://github.com/GenericMappingTools/pygmt/pull/1232/checks?check_run_id=2414751280#step:11:611:

____________________________ test_solar_terminators ____________________________
Error: Image dimensions did not match.
Expected shape: (892, 1836)
/home/runner/work/pygmt/pygmt/tmp-test-dir-with-unique-name/results/pygmt.tests.test_solar.test_solar_terminators/baseline.png
Actual shape: (893, 1947)
/home/runner/work/pygmt/pygmt/tmp-test-dir-with-unique-name/results/pygmt.tests.test_solar.test_solar_terminators/result.png
________ test_solar_set_terminator_datetime[terminator_datetime_string] ________
Error: Image dimensions did not match.
Expected shape: (892, 1836)
/home/runner/work/pygmt/pygmt/tmp-test-dir-with-unique-name/results/pygmt.tests.test_solar.test_solar_set_terminator_datetime_terminator_datetime_string/baseline.png
Actual shape: (893, 1947)
/home/runner/work/pygmt/pygmt/tmp-test-dir-with-unique-name/results/pygmt.tests.test_solar.test_solar_set_terminator_datetime_terminator_datetime_string/result.png
___________ test_solar_set_terminator_datetime[terminator_datetime1] ___________
Error: Image dimensions did not match.
Expected shape: (892, 1836)
/home/runner/work/pygmt/pygmt/tmp-test-dir-with-unique-name/results/pygmt.tests.test_solar.test_solar_set_terminator_datetime_terminator_datetime1/baseline.png
Actual shape: (893, 1947)
/home/runner/work/pygmt/pygmt/tmp-test-dir-with-unique-name/results/pygmt.tests.test_solar.test_solar_set_terminator_datetime_terminator_datetime1/result.png
________________________ test_solar_default_terminator _________________________
Error: Image dimensions did not match.
Expected shape: (892, 1836)
/home/runner/work/pygmt/pygmt/tmp-test-dir-with-unique-name/results/pygmt.tests.test_solar.test_solar_default_terminator/baseline.png
Actual shape: (893, 1947)
/home/runner/work/pygmt/pygmt/tmp-test-dir-with-unique-name/results/pygmt.tests.test_solar.test_solar_default_terminator/result.png

@weiji14
weiji14 self-requested a review April 30, 2021 02:29
@weiji14

Copy link
Copy Markdown
Member

@seisman, I'll push a commit to mark the failing fig.solar tests with xfail if that's ok with you.

@weiji14weiji14 mentioned this pull request Apr 30, 2021
@seisman

Copy link
Copy Markdown
MemberAuthor

@seisman, I'll push a commit to mark the failing fig.solar tests with xfail if that's ok with you.

Yes, please.

@weiji14
weiji14 merged commit 53caa74 into masterApr 30, 2021
@weiji14
weiji14 deleted the gmt-6.2.0rc1/solar branch April 30, 2021 20:14
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
…s#1232)
* Mark fig.solar tests with xfail
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenanceBoring but important stuff for the core devsskip-changelogSkip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@seisman@weiji14