Update pygmt.config baseline images for GMT 6.2.0rc1

[weiji14]

Description of proposed changes

Updates baseline images for the pygmt.config tests.

Addresses #1217

Reminders

• Run make format and make check to make sure the code follows the style guide.
• Add tests for new features or tests that would have caught the bug that you're fixing.
• Add new public functions/methods/classes to doc/api/index.rst.
• Write detailed docstrings for all functions/methods.
• If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

• /format: automatically format and lint the code
• /test-gmt-dev: run full tests on the latest GMT development version

[github-actions]

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status	Path
modified	pygmt/tests/baseline/test_config.png
modified	pygmt/tests/baseline/test_config_font_annot.png
modified	pygmt/tests/baseline/test_config_font_one.png
modified	pygmt/tests/baseline/test_config_format_time_map.png
modified	pygmt/tests/baseline/test_config_map_annot_offset.png
modified	pygmt/tests/baseline/test_config_map_grid_cross_size.png
modified	pygmt/tests/baseline/test_config_map_grid_pen.png
modified	pygmt/tests/baseline/test_config_map_tick_length.png
modified	pygmt/tests/baseline/test_config_map_tick_pen.png

Image diff(s)

Details

Added images

Modified images

Path	Old	New
test_config.png
test_config_font_annot.png
test_config_font_one.png
test_config_format_time_map.png
test_config_map_annot_offset.png
test_config_map_grid_cross_size.png
test_config_map_grid_pen.png
test_config_map_tick_length.png
test_config_map_tick_pen.png

Report last updated at commit d70061c

[seisman]

test_config_font_annot.png: the annotations near the needle are wrong, right?

[weiji14]

test_config_font_annot.png: the annotations near the needle are wrong, right?

Yeah, why is it 4 instead of -4? Upstream bug?

pygmt/pygmt/tests/test_config.py

Lines 55 to 64 in 3a4f2f5

	deftest_config_font_annot():
	"""
	Test that setting FONT_ANNOT config changes both FONT_ANNOT_PRIMARY and
	FONT_ANNOT_SECONDARY.
	"""
	fig=Figure()
	withconfig(FONT_ANNOT="6p,red"):
	fig.basemap(region=[0, 9, 0, 9], projection="C3/3/9c", compass="jTL+w4c+d4.5")
	fig.basemap(compass="jBR+w5c+d-4.5")
	returnfig

Same case with test_config_font_one.png

[maxrjones]

test_config_font_annot.png: the annotations near the needle are wrong, right?

Yeah, why is it 4 instead of -4? Upstream bug?

pygmt/pygmt/tests/test_config.py

Lines 55 to 64 in 3a4f2f5

	deftest_config_font_annot():
	"""
	Test that setting FONT_ANNOT config changes both FONT_ANNOT_PRIMARY and
	FONT_ANNOT_SECONDARY.
	"""
	fig=Figure()
	withconfig(FONT_ANNOT="6p,red"):
	fig.basemap(region=[0, 9, 0, 9], projection="C3/3/9c", compass="jTL+w4c+d4.5")
	fig.basemap(compass="jBR+w5c+d-4.5")
	returnfig

Same case with test_config_font_one.png

This is a consequence of FORMAT_GEO_MAP changing from ddd:mm:ss to ddd:mm:ssF. Feel free to open a GMT issue if you think FORMAT_GEO_MAP should not change these annotations.

[weiji14]

This is a consequence of FORMAT_GEO_MAP changing from ddd:mm:ss to ddd:mm:ssF. Feel free to open a GMT issue if you think FORMAT_GEO_MAP should not change these annotations.

Ok, I see at https://docs.generic-mapping-tools.org/6.2.0rc1/theme-settings.html#default-settings-for-build-in-themes that FORMAT_GEO_MAP defaults to ddd:mm:ssF for the new 'modern' GMT theme. where F is the 'Encode sign using WESN suffix'.

@meghanrjones, could you link to the discussion on why ddd:mm:ssF is used? Just want to have an informed opinion on this.

[maxrjones]

@meghanrjones, could you link to the discussion on why ddd:mm:ssF is used? Just want to have an informed opinion on this.

If there was a discussion about this, it would have happened in this PR: GenericMappingTools/gmt#3344. I do not remember any discussion after Paul's initial suggestion that maps should have the indicators on them, but I may have missed it.

It might be possible to have an auto option for FORMAT_GEO_MAP similar to the new auto selection for some other parameters, which would add WESN suffix for map annotations but not for the declination annotation. But, I haven't looked through how this would work when for example both basemap frame and compass are used so it's just an off-hand idea.

[weiji14]

@meghanrjones, could you link to the discussion on why ddd:mm:ssF is used? Just want to have an informed opinion on this.

If there was a discussion about this, it would have happened in this PR: GenericMappingTools/gmt#3344. I do not remember any discussion after Paul's initial suggestion that maps should have the indicators on them, but I may have missed it.

It might be possible to have an auto option for FORMAT_GEO_MAP similar to the new auto selection for some other parameters, which would add WESN suffix for map annotations but not for the declination annotation. But, I haven't looked through how this would work when for example both basemap frame and compass are used so it's just an off-hand idea.

Thanks Meghan. Combing through the ~250 comments, the only reference I can find on ddd.:mm:ssF is Paul's initial comment at GenericMappingTools/gmt#3344 (comment). I think it relates to his point on:

4. I think maps should have W-E-S-N indicators on them

which makes sense. Looking more closely at the changed figure, I think it's fine without the minus sign, the plot is actually correct because the declination annotation says 4°30W to indicate that it is pointing to the West. Before (in GMT 6.1.1), it would just use -4°30'.

In this case, can I get an approval for this PR? Unless there are other concerns.

[seisman]

I think it's weird to add E or W suffix to declination angles. Ping @PaulWessel to confirm whether it's a bug or expected.

[seisman]

After reading the magnetic declination wikipedia page, I realize that both -4°30' and 4°30'W are correct expressions for magnetic declination.

Now this PR is good to merge.

[michaelgrund]

Looks good to me.