Uh oh!
There was an error while loading. Please reload this page.
Add parameters to histogram - #1249
Conversation
There was a problem hiding this comment.
Still need to alias -L, -U, -V, -t and add the docstring in for these new parameters. Pro tip: copy them from https://github.com/GenericMappingTools/gmt/blob/master/doc/rst/source/histogram_common.rst_.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
weiji14
left a comment
There was a problem hiding this comment.
Just one minor comment on how we want to sort the docstrings, otherwise I'm happy with the content 😄
Uh oh!
There was an error while loading. Please reload this page.
seisman
left a comment
There was a problem hiding this comment.
Looks good to me, except a tiny comment.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com> Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
This wraps additional parameters for
histogram.Preview at https://pygmt-git-parameters-histogram-gmt.vercel.app/api/generated/pygmt.Figure.histogram.html
Continuation of work on #563
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version