Skip to content

Add parameters to histogram - #1249

Merged
seisman merged 27 commits into
masterfrom
parameters-histogram
May 12, 2021
Merged

Add parameters to histogram#1249
seisman merged 27 commits into
masterfrom
parameters-histogram

Conversation

@willschlitzer

@willschlitzerwillschlitzer commented Apr 29, 2021

Copy link
Copy Markdown
Contributor

This wraps additional parameters for histogram.

Preview at https://pygmt-git-parameters-histogram-gmt.vercel.app/api/generated/pygmt.Figure.histogram.html

Continuation of work on #563

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzerwillschlitzer added the enhancement Improving an existing feature label Apr 29, 2021
@willschlitzerwillschlitzer added this to the 0.4.0 milestone Apr 29, 2021
@willschlitzerwillschlitzer self-assigned this Apr 29, 2021
@willschlitzerwillschlitzer changed the title WIP: Add available parameters to histogramWIP: Add parameters to histogramApr 29, 2021

@weiji14weiji14 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to alias -L, -U, -V, -t and add the docstring in for these new parameters. Pro tip: copy them from https://github.com/GenericMappingTools/gmt/blob/master/doc/rst/source/histogram_common.rst_.

Comment threadpygmt/src/histogram.py Outdated
Comment threadpygmt/src/histogram.py Outdated
Comment threadpygmt/src/histogram.py Outdated
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
@willschlitzerwillschlitzer changed the title WIP: Add parameters to histogramAdd parameters to histogramMay 5, 2021
@willschlitzer
willschlitzer marked this pull request as ready for review May 5, 2021 16:47
Comment threadpygmt/src/histogram.py Outdated
Comment threadpygmt/src/histogram.py Outdated
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Comment threadpygmt/src/histogram.py Outdated
Comment threadpygmt/src/histogram.py Outdated
Comment threadpygmt/src/histogram.py Outdated
Comment threadpygmt/src/histogram.py Outdated
Comment threadpygmt/src/histogram.py Outdated
Comment threadpygmt/src/histogram.py Outdated
willschlitzerand others added 2 commits May 9, 2021 07:13
Comment threadpygmt/src/histogram.py Outdated
Comment threadpygmt/src/histogram.py Outdated
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>

@weiji14weiji14 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment on how we want to sort the docstrings, otherwise I'm happy with the content 😄

Comment threadpygmt/src/histogram.py Outdated
@weiji14weiji14 added the final review call This PR requires final review and approval from a second reviewer label May 11, 2021

@seismanseisman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, except a tiny comment.

Comment threadpygmt/src/histogram.py
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@seismanseisman removed the final review call This PR requires final review and approval from a second reviewer label May 12, 2021
@seisman
seisman merged commit ab1636d into masterMay 12, 2021
@seisman
seisman deleted the parameters-histogram branch May 12, 2021 13:39
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementImproving an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@willschlitzer@seisman@michaelgrund@weiji14