Skip to content

Add categorical colorbars for plot, plot3d and line colors gallery examples - #1267

Merged
seisman merged 11 commits into
masterfrom
cat-update-plot-plot3d
May 13, 2021
Merged

Add categorical colorbars for plot, plot3d and line colors gallery examples#1267
seisman merged 11 commits into
masterfrom
cat-update-plot-plot3d

Conversation

@michaelgrund

@michaelgrundmichaelgrund commented May 10, 2021•
edited by seisman
Loading

Copy link
Copy Markdown
Member

Description of proposed changes

As discussed in #1259 this PR fixes issues appearing during cpt creation and adds categorical colorbars to the examples.

Previews:

Closes#1259.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@michaelgrund
WIP: Add categorical colorbars for plot and plot3d gallery examples
5d6c480
As discussed in #1259 this PR fixes issues appearing during cpt creation and adds categorical colorbars to the examples.
@michaelgrundmichaelgrund added documentation Improvements or additions to documentation enhancement Improving an existing feature labels May 10, 2021
@michaelgrund
michaelgrund marked this pull request as draft May 10, 2021 11:08
@michaelgrundmichaelgrund added this to the 0.4.0 milestone May 10, 2021
@michaelgrund
michaelgrund marked this pull request as ready for review May 10, 2021 15:52
@michaelgrundmichaelgrund linked an issue May 10, 2021 that may be closed by this pull request
Add categorical colorbars for plot and plot3d gallery examples #1259
Closed
@michaelgrundmichaelgrund changed the title WIP: Add categorical colorbars for plot and plot3d gallery examplesWIP: Add categorical colorbars for plot, plot3d and line colors gallery examplesMay 10, 2021
@michaelgrundmichaelgrund changed the title WIP: Add categorical colorbars for plot, plot3d and line colors gallery examplesAdd categorical colorbars for plot, plot3d and line colors gallery examplesMay 11, 2021
willschlitzer
willschlitzer reviewed May 11, 2021
View reviewed changes
Comment threadexamples/gallery/3d_plots/scatter3d.py Outdated
weiji14
weiji14 reviewed May 11, 2021
View reviewed changes
Comment threadexamples/gallery/3d_plots/scatter3d.py Outdated
Comment threadexamples/gallery/3d_plots/scatter3d.py
seisman
seisman reviewed May 11, 2021
View reviewed changes
Comment threadexamples/gallery/lines/line_custom_cpt.py Outdated
seisman
seisman reviewed May 11, 2021
View reviewed changes
Comment threadexamples/gallery/symbols/points_categorical.py Outdated
@michaelgrund@seisman
Update examples/gallery/lines/line_custom_cpt.py
8ed28a4
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
seisman approved these changes May 12, 2021
View reviewed changes

@seismanseisman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@seismanseisman added final review call This PR requires final review and approval from a second reviewer and removed enhancement Improving an existing feature labels May 12, 2021
weiji14
weiji14 approved these changes May 12, 2021
View reviewed changes

@weiji14weiji14 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with this, just two small suggestions 😄

Comment threadexamples/gallery/3d_plots/scatter3d.py Outdated
Comment threadexamples/gallery/3d_plots/scatter3d.py Outdated
@michaelgrund@weiji14
Apply suggestions from code review
b46966b
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
@seismanseisman removed the final review call This PR requires final review and approval from a second reviewer label May 13, 2021
@seisman
seisman merged commit d32fff5 into masterMay 13, 2021
@seisman
seisman deleted the cat-update-plot-plot3d branch May 13, 2021 13:37
@yvonnefroehlichyvonnefroehlich mentioned this pull request Aug 12, 2022
Merged
6 tasks
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@michaelgrund@seisman
@weiji14@willschlitzerJosh Sixsmith
Add categorical colorbars for plot, plot3d and line colors gallery ex…
35aeb12
…amples (GenericMappingTools#1267)
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Co-authored-by: Will Schlitzer <schlitzer90@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willschlitzerwillschlitzerwillschlitzer left review comments
@seismanseismanseisman approved these changes
@weiji14weiji14weiji14 approved these changes

Assignees

No one assigned

Labels

documentationImprovements or additions to documentation

Projects

None yet

Milestone

0.4.0

Development

Successfully merging this pull request may close these issues.

Add categorical colorbars for plot and plot3d gallery examples

4 participants

@michaelgrund@seisman@weiji14@willschlitzer