Skip to content

Wrap grdlandmask - #1273

Merged
willschlitzer merged 33 commits into
masterfrom
wrap-grdlandmask
May 26, 2021
Merged

Wrap grdlandmask#1273
willschlitzer merged 33 commits into
masterfrom
wrap-grdlandmask

Conversation

@willschlitzer

@willschlitzerwillschlitzer commented May 14, 2021

Copy link
Copy Markdown
Contributor

This pull request wraps the grdlandmask module.

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzerwillschlitzer added the feature Brand new feature label May 14, 2021
@willschlitzerwillschlitzer added this to the 0.4.0 milestone May 14, 2021
@willschlitzerwillschlitzer self-assigned this May 14, 2021
@willschlitzer

Copy link
Copy Markdown
ContributorAuthor

I'm running into a newfound problem with this module. When I run:

import pygmt
new_grid = pygmt.grdlandmask(increment=1, region = [-5, 5, -5, 5])

I receive: TypeError: 'module' object is not callable

I've done the typical trouble shooting (confirmed I'm in the correct conda environment, have the appropriate git branch activated, checked the import statements and function to make sure it's in line with other modules, and, of course, shut it down and started it up again) so I'm not sure why I'm getting this issue. @weiji14@seisman any ideas?

Comment threadpygmt/src/__init__.py Outdated
Comment threadpygmt/src/grdlandmask.py Outdated
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
@willschlitzerwillschlitzer changed the title WIP: Wrap grdlandmaskWrap grdlandmaskMay 18, 2021
@willschlitzer
willschlitzer marked this pull request as ready for review May 18, 2021 08:04
Comment threadpygmt/src/grdlandmask.py Outdated
Co-authored-by: Meghan Jones <meghanj@hawaii.edu>
@seismanseisman removed the final review call This PR requires final review and approval from a second reviewer label May 24, 2021
@seisman

Copy link
Copy Markdown
Member

@willschlitzer Feel free to merge this PR after all tests pass.

Comment threadpygmt/src/grdlandmask.py Outdated
Comment threadpygmt/src/grdlandmask.py Outdated
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>

@weiji14weiji14 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some final suggestions. Feel free to merge after the tests pass.

Comment threadpygmt/src/grdlandmask.py Outdated
Comment threadpygmt/tests/test_grdlandmask.py Outdated
Comment threadpygmt/tests/test_grdlandmask.py Outdated
Comment threadpygmt/src/grdlandmask.py Outdated
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
@willschlitzer
willschlitzer merged commit 46f739a into masterMay 26, 2021
@willschlitzer
willschlitzer deleted the wrap-grdlandmask branch May 26, 2021 10:18
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
* Add grdlandmask.py and test_grdlandmask.py
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Yao Jiayuan <coreman.seism@gmail.com>
Co-authored-by: Meghan Jones <meghanj@hawaii.edu>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

featureBrand new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@willschlitzer@seisman@maxrjones@michaelgrund@weiji14@core-man