Uh oh!
There was an error while loading. Please reload this page.
Wrap grdlandmask - #1273
Conversation
willschlitzer
commented
May 17, 2021
I'm running into a newfound problem with this module. When I run: I receive: I've done the typical trouble shooting (confirmed I'm in the correct conda environment, have the appropriate git branch activated, checked the import statements and function to make sure it's in line with other modules, and, of course, shut it down and started it up again) so I'm not sure why I'm getting this issue. @weiji14@seisman any ideas? |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Meghan Jones <meghanj@hawaii.edu>
seisman
commented
May 24, 2021
@willschlitzer Feel free to merge this PR after all tests pass. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
weiji14
left a comment
There was a problem hiding this comment.
Just some final suggestions. Feel free to merge after the tests pass.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
* Add grdlandmask.py and test_grdlandmask.py Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com> Co-authored-by: Dongdong Tian <seisman.info@gmail.com> Co-authored-by: Yao Jiayuan <coreman.seism@gmail.com> Co-authored-by: Meghan Jones <meghanj@hawaii.edu>
This pull request wraps the
grdlandmaskmodule.Fixes #
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version