Allow pandas.Series inputs to fig.histogram and pygmt.info - #1329
Merged
Conversation
Let 1D `pandas.Series` inputs work properly by refactoring the `virtualfile_from_data` function. Also added two tests in test_histogram.py and test_info.py to ensure this works.
weiji14
force-pushed
the
histogram_pandas_series
branch
from
June 11, 2021 03:32
9a0c285 to
9ff022d
Compare
maxrjones
reviewed
Jun 11, 2021
weiji14
marked this pull request as ready for review
June 19, 2021 10:31
maxrjones
approved these changes
Jun 19, 2021
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…ppingTools#1329) Let 1D pandas.Series inputs work properly by modifying the virtualfile_from_data function. Also added two tests in test_histogram.py and test_info.py to ensure this works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Let 1D
pandas.Seriesinputs work properly by modifying thevirtualfile_from_datafunction. Also added two tests in test_histogram.py and test_info.py to ensure this works.The implementation works by checking whether the input data is a
pandas.Series, and then use_data = np.atleast_2d(np.asanyarray(data).T). Specifically, duck-typing is used to see if ato_frame(i.e. to DataFrame) function exists. This duck-typing should theoretically work forpandas.Seriesanddask.Seriesobjects:Fixes #1253
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version