Uh oh!
There was an error while loading. Please reload this page.
Changelog entry for v0.4.0 - #1341
Conversation
maxrjones
commented
Jun 19, 2021
For updating the citation information, the AUTHORSHIP.md file says that "The order of authors will be defined by the number of commits to the repository (git shortlog -sne). The order can also be changed on a case-by-case basis." How do I know whether any of the current order reflects a case-by-case basis or whether I should update based on |
weiji14
commented
Jun 19, 2021
See previous discussion at #1047 (comment). Will leave it up to you to take a first stab at the order :) Just to clarify, that line refers to the Zenodo citation order. The release note authors order should go strictly by |
maxrjones
commented
Jun 19, 2021
OK, I guess I wasn't paying good attention for that release :) Thanks for the note. |
maxrjones
commented
Jun 19, 2021
maxrjones
commented
Jun 20, 2021
seisman
commented
Jun 20, 2021
I don't think it's an issue. The badges are working on the pypi site (https://pypi.org/project/pygmt/) and we don't make changes to badges since v0.3.1. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Yao Jiayuan <coreman.seism@gmail.com>
michaelgrund
left a comment
There was a problem hiding this comment.
From my side everything looks fine. All open points are considered. Great work!
core-man
left a comment
There was a problem hiding this comment.
I did not check the authors, but all the other looks great.
maxrjones
commented
Jun 20, 2021
Should I wait for Wei Ji to approve as well or is OK to move forward with the comments addressed and the three approvals? |
core-man
commented
Jun 20, 2021
Perhaps it would better to wait for his approval too, since it does not matter to release v0.4 a few hours earlier or later. |
weiji14
left a comment
There was a problem hiding this comment.
Just one suggestion, otherwise all good!
Uh oh!
There was an error while loading. Please reload this page.
* Add changelog entry to changes.md * Update release highlights * Reorganize contributor list * Update citation * Update version_switch.js * Update documentation link Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com> Co-authored-by: Dongdong Tian <seisman.info@gmail.com> Co-authored-by: Yao Jiayuan <coreman.seism@gmail.com>

Description of proposed changes
This PR is a draft changelog entry for v0.4.0.
Preview: https://pygmt-git-changelog-release-gmt.vercel.app/changes.html#changelog
Previous release at #1047
Changelog made by following the instructions at https://github.com/GenericMappingTools/pygmt/blob/master/doc/maintenance.md#updating-the-changelog
To do:
Relates to #1333
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version