Wrap grdsample by willschlitzer · Pull Request #1380 · GenericMappingTools/pygmt

willschlitzer · 2021-07-08T15:54:06Z

This pull requests wraps the GMT module grdsample.

Reminders

Run make format and make check to make sure the code follows the style guide.
Add tests for new features or tests that would have caught the bug that you're fixing.
Add new public functions/methods/classes to doc/api/index.rst.
Write detailed docstrings for all functions/methods.
If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

/format: automatically format and lint the code
/test-gmt-dev: run full tests on the latest GMT development version

weiji14

Thanks @willschlitzer! Just a few suggestions regarding the use of common aliases.

Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>

weiji14

Looks good to me. But please hold off on merging until we decide on whether we want a PyGMT v0.4.1 release, or go straight to v0.5.0 as discussed in #1356 (comment)

weiji14

Thanks for your patience @willschlitzer, now that the v0.4.1 tag is behind, we can finally finish this PR (and all the other ones you have lined up). Could you please resolve the conflict on decorators.py and fix one tiny issue I suggested below?

Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>

willschlitzer · 2021-08-08T08:18:49Z

@weiji14 I made the changes you suggested

michaelgrund

Fine to merge after the suggestions by @seisman are implemented!

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

seisman · 2021-08-08T20:40:21Z

+@use_alias(
+ G="outgrid",
+ J="projection",
+ I="increment",


It seems other modules (e.g., grdfilter) use the alias spacing rather than increment. We should keep the alias consistent, no?

weiji14

🚀

*Wrap GMT module grdsample *Add tests for grdsample Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com> Co-authored-by: Michael Grund <23025878+michaelgrund@users.noreply.github.com> Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

add grdsample.py and import statements
9891e49

willschlitzer added the feature Brand new feature label Jul 8, 2021

willschlitzer added this to the 0.5.0 milestone Jul 8, 2021

willschlitzer self-assigned this Jul 8, 2021

willschlitzer added 5 commits July 8, 2021 16:55

add grdsample to index.rst
8b2a778

fix comma spacing
54fde72

add grdsample docstring
bc60076

add parameter docstrings
33a9960

formatting fix
5d0aeb5

vercelBottemporarily deployed to Preview July 8, 2021 16:31 Inactive

add test_grdsample.py
7886931

vercelBottemporarily deployed to Preview July 8, 2021 16:48 Inactive

remove unused imports
22aafe5

vercelBottemporarily deployed to Preview July 9, 2021 14:31 Inactive

willschlitzer changed the title ~~WIP: Wrap grdsample~~Wrap grdsampleJul 11, 2021

add single line description for module in docstring
54f2ada

vercelBottemporarily deployed to Preview July 12, 2021 16:42 Inactive

weiji14 reviewed Jul 13, 2021
View reviewed changes

Comment threadpygmt/src/grdsample.py Outdated
Comment threadpygmt/src/grdsample.py Outdated
Comment threadpygmt/src/grdsample.py Outdated
Comment threadpygmt/src/grdsample.py
Comment threadpygmt/src/grdsample.py

Apply suggestions from code review
9f8c0c7
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>

vercelBottemporarily deployed to Preview July 14, 2021 15:01 Inactive

add bool option to registration parameter
593d712

vercelBottemporarily deployed to Preview July 14, 2021 15:09 Inactive

willschlitzer marked this pull request as ready for review July 16, 2021 15:56

move "interpolation" to COMMON_OPTIONS in decorators.py
2ff1550

vercelBottemporarily deployed to Preview July 16, 2021 16:37 Inactive

weiji14 reviewed Jul 17, 2021
View reviewed changes

Comment threadpygmt/helpers/decorators.py Outdated
Comment threadpygmt/src/grdsample.py Outdated

Apply suggestions from code review
ad609c3
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>

vercelBottemporarily deployed to Preview July 17, 2021 05:57 Inactive

weiji14 approved these changes Jul 21, 2021
View reviewed changes

maxrjones mentioned this pull request Jul 21, 2021
Change main branch from "master" to "main" #1356
Closed

weiji14 added the final review call This PR requires final review and approval from a second reviewer label Aug 8, 2021

weiji14 reviewed Aug 8, 2021
View reviewed changes

Comment threadpygmt/src/grdsample.py Outdated

Merge branch 'main' into wrap-grdsample
ddcb3c5

vercelBottemporarily deployed to Preview August 8, 2021 08:11 Inactive

Apply suggestions from code review
ac5fee4
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>

vercelBottemporarily deployed to Preview August 8, 2021 08:19 Inactive

seisman approved these changes Aug 8, 2021
View reviewed changes

Comment threadpygmt/tests/test_grdsample.py Outdated
Comment threadpygmt/tests/test_grdsample.py Outdated

seisman reviewed Aug 8, 2021
View reviewed changes

Comment threadpygmt/tests/test_grdsample.py Outdated
Comment threadpygmt/tests/test_grdsample.py Outdated

michaelgrund approved these changes Aug 8, 2021
View reviewed changes

Apply suggestions from code review
4727aae
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

vercelBottemporarily deployed to Preview August 8, 2021 19:49 Inactive

weiji14 mentioned this pull request Aug 8, 2021
grdsample alternative in pygmt #1422
Closed

seisman reviewed Aug 8, 2021
View reviewed changes

willschlitzer commented Aug 9, 2021
View reviewed changes

Comment threadpygmt/src/grdsample.py Outdated

willschlitzer commented Aug 9, 2021
View reviewed changes

Comment threadpygmt/src/grdsample.py Outdated

willschlitzer commented Aug 9, 2021
View reviewed changes

Comment threadpygmt/src/grdsample.py Outdated

willschlitzer commented Aug 9, 2021
View reviewed changes

Comment threadpygmt/tests/test_grdsample.py Outdated

Apply suggestions from code review
09a43de

vercelBottemporarily deployed to Preview August 9, 2021 07:02 Inactive

Merge branch 'main' into wrap-grdsample
75c3a51

vercelBottemporarily deployed to Preview August 9, 2021 08:37 Inactive

weiji14 approved these changes Aug 9, 2021
View reviewed changes

willschlitzer merged commit 85d78d6 into mainAug 9, 2021

willschlitzer deleted the wrap-grdsample branch August 9, 2021 11:10

seisman removed the final review call This PR requires final review and approval from a second reviewer label Aug 9, 2021

weiji14 mentioned this pull request Sep 18, 2021
Add common alias spacing (-I) for specifying grid increments #1288
Merged
31 tasks

weiji14 mentioned this pull request Jan 31, 2022
Add link to GMT full option list for grdproject, grdsample and project #1716
Merged
6 tasks

seisman mentioned this pull request Feb 14, 2026
pygmt.grdsample: Resample a grid onto a new lattice #4416
Closed
13 tasks

Uh oh!

Conversation

willschlitzer commented Jul 8, 2021• edited by weiji14 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

weiji14 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

weiji14 left a comment

Choose a reason for hiding this comment

Uh oh!

weiji14 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

willschlitzer commented Aug 8, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

michaelgrund left a comment

Choose a reason for hiding this comment

Uh oh!

seismanAug 8, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

weiji14 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

willschlitzer commented Jul 8, 2021•
edited by weiji14
Loading