Skip to content

Update/add grdlandmask parameters and aliases - #1423

Merged
michaelgrund merged 22 commits into
mainfrom
update-grdlandmask
Aug 20, 2021
Merged

Update/add grdlandmask parameters and aliases#1423
michaelgrund merged 22 commits into
mainfrom
update-grdlandmask

Conversation

@michaelgrund

@michaelgrundmichaelgrund commented Aug 9, 2021

Copy link
Copy Markdown
Member

Description of proposed changes

As discussed in #1421 this PR adds further parameters and corresponding aliases to grdlandmask.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@michaelgrundmichaelgrund added enhancement Improving an existing feature skip-changelog Skip adding Pull Request to changelog labels Aug 9, 2021
@michaelgrundmichaelgrund added this to the 0.5.0 milestone Aug 9, 2021
@michaelgrundmichaelgrund self-assigned this Aug 9, 2021
@michaelgrund
michaelgrund marked this pull request as draft August 9, 2021 05:34
@michaelgrundmichaelgrund linked an issue Aug 9, 2021 that may be closed by this pull request
Missing (required) parameters in grdlandmask #1421
Closed
@michaelgrundmichaelgrund mentioned this pull request Aug 9, 2021
Merged
5 tasks
@michaelgrundmichaelgrund changed the title WIP: Update/add grdlandmask parameters and aliasesUpdate/add grdlandmask parameters and aliasesAug 11, 2021
@michaelgrund
michaelgrund marked this pull request as ready for review August 11, 2021 07:11
weiji14
weiji14 reviewed Aug 11, 2021
View reviewed changes

@weiji14weiji14 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @michaelgrund! By the way, could you swap the order of grdlandmask and grdgradient at https://github.com/GenericMappingTools/pygmt/blame/v0.4.1/doc/api/index.rst#L95-L96? Just noticed they weren't in alphabetical order.

Comment threadpygmt/src/grdlandmask.py
Comment threadpygmt/src/grdlandmask.py Outdated
@weiji14weiji14 removed the enhancement Improving an existing feature label Aug 11, 2021
seisman
seisman reviewed Aug 12, 2021
View reviewed changes
Comment threadpygmt/src/grdlandmask.py Outdated
michaelgrund
michaelgrund commented Aug 13, 2021
View reviewed changes

@michaelgrundmichaelgrund left a comment

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @seisman!

@michaelgrund@seisman
Apply suggestions from code review
6456fac
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
seisman reviewed Aug 16, 2021
View reviewed changes
Comment threadpygmt/src/grdlandmask.py Outdated
Comment threadpygmt/src/grdlandmask.py Outdated
@michaelgrund@seisman
Apply suggestions from code review
342efa7
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@michaelgrund

michaelgrund commented Aug 17, 2021

Copy link
Copy Markdown
MemberAuthor

/format

seisman
seisman reviewed Aug 18, 2021
View reviewed changes
Comment threadpygmt/src/grdlandmask.py Outdated
@michaelgrund@seisman
Update pygmt/src/grdlandmask.py
b31162e
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@seismanseisman added the final review call This PR requires final review and approval from a second reviewer label Aug 18, 2021
@michaelgrund
michaelgrund merged commit 81db512 into mainAug 20, 2021
@michaelgrund
michaelgrund deleted the update-grdlandmask branch August 20, 2021 11:41
@michaelgrundmichaelgrund removed the final review call This PR requires final review and approval from a second reviewer label Aug 20, 2021
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@michaelgrund@weiji14
@seismanJosh Sixsmith
Update/add grdlandmask parameters and aliases (GenericMappingTools#1423)
410a77b
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@weiji14weiji14 mentioned this pull request Jan 2, 2024
Merged
7 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seismanseismanseisman approved these changes
@weiji14weiji14weiji14 approved these changes

Assignees

@michaelgrundmichaelgrund

Labels

enhancementImproving an existing feature

Projects

None yet

Milestone

0.5.0

Development

Successfully merging this pull request may close these issues.

Missing (required) parameters in grdlandmask

4 participants

@michaelgrund@seisman@weiji14@actions-bot