Skip to content

Wrap sph2grd - #1434

Merged
willschlitzer merged 22 commits into
mainfrom
wrap-sph2grd
Sep 27, 2021
Merged

Wrap sph2grd#1434
willschlitzer merged 22 commits into
mainfrom
wrap-sph2grd

Conversation

@willschlitzer

@willschlitzerwillschlitzer commented Aug 10, 2021•
edited by weiji14
Loading

Copy link
Copy Markdown
Contributor

This pull request wraps the GMT module sph2grd.

Preview docs at https://pygmt-git-wrap-sph2grd-gmt.vercel.app/api/generated/pygmt.sph2grd.html

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzerwillschlitzer added the feature Brand new feature label Aug 10, 2021
@willschlitzerwillschlitzer added this to the 0.5.0 milestone Aug 10, 2021
@willschlitzerwillschlitzer self-assigned this Aug 10, 2021
@willschlitzer
Remove unused import
f7a3e9b
Remove GMTInvalidInput import statement
@willschlitzer
Add xarray functions to test outgrid info
50e0382
Remove the use of grdinfo and use xarray min, max, median, and mean functions to test data in outgrid
@willschlitzer
Add rtol parameter for npt assertions
b4f0284
@willschlitzerwillschlitzer changed the title WIP: Wrap sph2grdWrap sph2grdSep 10, 2021
@willschlitzer
willschlitzer marked this pull request as ready for review September 10, 2021 01:50
maxrjones
maxrjones reviewed Sep 10, 2021
View reviewed changes
Comment threaddoc/api/index.rst Outdated
Comment threadpygmt/src/sph2grd.py Outdated
Comment threadpygmt/src/sph2grd.py Outdated
@willschlitzerMeghan Jones
Apply suggestions from code review
41400f9
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
@maxrjonesmaxrjones mentioned this pull request Sep 11, 2021
Closed
weiji14
weiji14 reviewed Sep 25, 2021
View reviewed changes
Comment threadpygmt/src/sph2grd.py Outdated
Comment threadpygmt/src/sph2grd.py
Comment threadpygmt/src/sph2grd.py Outdated
Comment threadpygmt/src/sph2grd.py
Comment threadpygmt/src/sph2grd.py Outdated
Comment threadpygmt/tests/test_sph2grd.py Outdated
Comment threadpygmt/tests/test_sph2grd.py Outdated
Comment threadpygmt/src/sph2grd.py Outdated
@willschlitzer@weiji14
Apply suggestions from code review
24f0565
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
weiji14
weiji14 approved these changes Sep 26, 2021
View reviewed changes

@weiji14weiji14 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ready for final review. Just some minor comments to fix the lint error and add some common aliases.

Also, remember to cache the @EGM96_to_36.txt dataset as mentioned in #1434 (comment). You can do it directly in this PR instead of opening a new one.

Comment threadpygmt/src/sph2grd.py Outdated
Comment threadpygmt/src/sph2grd.py
Comment threadpygmt/src/sph2grd.py Outdated
Comment threadpygmt/src/sph2grd.py
@weiji14weiji14 added the final review call This PR requires final review and approval from a second reviewer label Sep 26, 2021
willschlitzerand others added 2 commits September 26, 2021 13:07
@willschlitzer@weiji14
Apply suggestions from code review
25d15dd
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
@willschlitzer
add file cache
f93b98c
seisman
seisman reviewed Sep 26, 2021
View reviewed changes
Comment threadpygmt/src/sph2grd.py Outdated
seisman
seisman reviewed Sep 26, 2021
View reviewed changes
Comment threadpygmt/src/sph2grd.py Outdated
@willschlitzer@seisman
Update pygmt/src/sph2grd.py
9315af0
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@willschlitzerwillschlitzer removed the final review call This PR requires final review and approval from a second reviewer label Sep 27, 2021
@willschlitzer
willschlitzer merged commit e716971 into mainSep 27, 2021
@willschlitzer
willschlitzer deleted the wrap-sph2grd branch September 27, 2021 06:51
@seismanseisman mentioned this pull request Sep 28, 2021
Merged
5 tasks
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@willschlitzerMeghan Jones
@weiji14@seismanJosh Sixsmith
Wrap sph2grd (GenericMappingTools#1434)
681600f
Wrapping the sph2grd function.
*Add sph2grd tests
*Wrap required and common aliases
*Add sph2grd to API index
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@seismanseisman mentioned this pull request Apr 11, 2026
Closed
7 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxrjonesmaxrjonesmaxrjones left review comments
@seismanseismanseisman approved these changes
@weiji14weiji14weiji14 approved these changes

Assignees

@willschlitzerwillschlitzer

Labels

featureBrand new feature

Projects

None yet

Milestone

0.5.0

Development

Successfully merging this pull request may close these issues.

4 participants

@willschlitzer@seisman@maxrjones@weiji14