Uh oh!
There was an error while loading. Please reload this page.
Wrap blockmode - #1456
Conversation
maxrjones
commented
Aug 19, 2021
/format |
maxrjones
left a comment
There was a problem hiding this comment.
Great work, @arleaman! I made a couple small formatting suggestions. Apart from that, there are two more steps needed before adding this module to PyGMT:
- Add
blockmodeto/doc/api/index.rstin line 84. - Add a test for blockmode. I can provide some instructions for how to add a test for this module, if you expect to have time to work with us on finishing up the pull request?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
seisman
commented
Aug 29, 2021
Ping @arleaman to finalize this PR if available. |
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
seisman
left a comment
There was a problem hiding this comment.
Looks good to me except two minor suggestions.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
arleaman
commented
Sep 1, 2021
Thanks @meghanrjones! I'll be happy to add tests for the module with some additional guidance!
|
seisman
commented
Sep 2, 2021
I think we still need one test for blockmode to make sure that the function can be called. |
maxrjones
commented
Sep 2, 2021
Great, let's add a test! @arleaman, here is some guidance:
|
arleaman
commented
Sep 13, 2021
Thanks for the help @meghanrjones! |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
maxrjones
left a comment
There was a problem hiding this comment.
Great work! 🎉
I'll leave this open for a short while in case others have any last minute comments.
The alias of d is nodata in other modules, but was incorrectly set to data in blockmean and blockmode. This PR fixes the problem. blockmode was wrapped in #1456 (after v0.4.1), blockmean was wrapped in #1092 but the wrong alias was added in #1500 (after v0.4.1). Thus, the change won't go into the deprecation cycle.
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu> Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
…ngTools#1563) The alias of d is nodata in other modules, but was incorrectly set to data in blockmean and blockmode. This PR fixes the problem. blockmode was wrapped in GenericMappingTools#1456 (after v0.4.1), blockmean was wrapped in GenericMappingTools#1092 but the wrong alias was added in GenericMappingTools#1500 (after v0.4.1). Thus, the change won't go into the deprecation cycle.

Description of proposed changes
Wrap blockmode
Addresses #1091
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version