Skip to content

Add missing aliases to sphdistance - #1516

Merged
seisman merged 7 commits into
mainfrom
add-params-sphdistance
Oct 27, 2021
Merged

Add missing aliases to sphdistance#1516
seisman merged 7 commits into
mainfrom
add-params-sphdistance

Conversation

@willschlitzer

@willschlitzerwillschlitzer commented Sep 17, 2021

Copy link
Copy Markdown
Contributor

This pull request is a follow up to #1383, and wraps additional optional parameters for sphdistance.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzerwillschlitzer added the enhancement Improving an existing feature label Sep 17, 2021
@willschlitzerwillschlitzer added this to the 0.5.0 milestone Sep 17, 2021
@willschlitzerwillschlitzer self-assigned this Sep 17, 2021
@weiji14weiji14 added documentation Improvements or additions to documentation and removed enhancement Improving an existing feature labels Oct 5, 2021
@willschlitzerwillschlitzer changed the title Add optional parameters to sphdistanceAdd missing aliases to sphdistanceOct 5, 2021
@willschlitzer
willschlitzer marked this pull request as ready for review October 5, 2021 18:54
@willschlitzerwillschlitzer added the skip-changelog Skip adding Pull Request to changelog label Oct 5, 2021
maxrjones
maxrjones reviewed Oct 6, 2021
View reviewed changes
Comment threadpygmt/src/sphdistance.py Outdated
Comment threadpygmt/src/sphdistance.py Outdated
Comment threadpygmt/src/sphdistance.py
Comment threadpygmt/src/sphdistance.py
Comment on lines +72 to +79
Read the information pertaining to each Voronoi
polygon (the unique node lon, lat and polygon area) from a separate
file [Default acquires this information from the ASCII segment
headers of the output file]. Required if binary input via `voronoi`
is used.
voronoi : str
Append the name of a file with pre-calculated Voronoi polygons
[Default performs the Voronoi construction on input data].

@maxrjonesmaxrjonesOct 6, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Especially one sphtriangulate is wrapped, we will need to open a separate issue to discuss how to pass these data to sphdistance from memory rather than relying on writing/reading files.

@willschlitzerwillschlitzer mentioned this pull request Oct 7, 2021
Closed
35 tasks
seisman
seisman reviewed Oct 10, 2021
View reviewed changes
Comment threadpygmt/src/sphdistance.py Outdated
@willschlitzerMeghan Jones@seisman
Apply suggestions from code review
17f9f53
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@maxrjones

maxrjones commented Oct 23, 2021

Copy link
Copy Markdown
Member

@willschlitzer, would you mind merging main into this branch to fix the vercel preview?

@willschlitzer
willschlitzer requested a review from a teamOctober 25, 2021 09:54
seisman
seisman reviewed Oct 25, 2021
View reviewed changes
Comment threadpygmt/src/sphdistance.py Outdated
seisman
seisman approved these changes Oct 25, 2021
View reviewed changes

@seismanseisman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@seismanseisman added final review call This PR requires final review and approval from a second reviewer and removed skip-changelog Skip adding Pull Request to changelog labels Oct 25, 2021
@willschlitzer@seisman
Apply suggestions from code review
e1b12c8
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@willschlitzer

willschlitzer commented Oct 26, 2021

Copy link
Copy Markdown
ContributorAuthor

@GenericMappingTools/pygmt-admin Could I get one of the admins to merge this? I'm not able to with the failed windows-latest test.

@seisman
seisman merged commit 8ea26d8 into mainOct 27, 2021
@seisman
seisman deleted the add-params-sphdistance branch October 27, 2021 03:17
@seismanseisman removed the final review call This PR requires final review and approval from a second reviewer label Oct 27, 2021
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@willschlitzerMeghan Jones
@seismanJosh Sixsmith
Add missing aliases to sphdistance (GenericMappingTools#1516)
37472ca
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxrjonesmaxrjonesmaxrjones left review comments
@seismanseismanseisman approved these changes
@michaelgrundmichaelgrundmichaelgrund approved these changes

Assignees

@willschlitzerwillschlitzer

Labels

documentationImprovements or additions to documentation

Projects

None yet

Milestone

0.5.0

Development

Successfully merging this pull request may close these issues.

5 participants

@willschlitzer@maxrjones@seisman@michaelgrund@weiji14