Uh oh!
There was an error while loading. Please reload this page.
NEP29: Set minimum required version to NumPy 1.19+ - #1675
Conversation
seisman
left a comment
There was a problem hiding this comment.
Looks good to me.
@michaelgrund Better to change the title to "NEP29: Set minimum required version to NumPy 1.19+" following previous PRs #1430, #1074
weiji14
left a comment
There was a problem hiding this comment.
Yep, agree with @seisman's statement to change the title above. Also, we'll need to update the branch protection rules at https://github.com/GenericMappingTools/pygmt/settings/branches to require Python 3.7 / NumPy 1.19 before merging.
michaelgrund
commented
Dec 20, 2021
Thanks 😉 |
michaelgrund
commented
Dec 20, 2021
Good to know, that needs to be done by an owner, correct @weiji14 ? |
weiji14
commented
Dec 20, 2021
Yep, just someone with admin privileges. I've done it already. Should be good to merge once status checks all pass. |
michaelgrund
commented
Dec 20, 2021
Great, thanks 😉 |
Description of proposed changes
Following NEP29 policy where NumPy 1.18 is to be dropped on or after Dec. 22, 2021 (in a minor version increment, i.e. for PyGMT v0.6.0). Bumps minimum supported NumPy version to 1.19 in the setup.py, requirements.txt and environment.yml files. Also update installation documentation and set CI tests to run on NumPy 1.19.
xref: #1430
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version