Skip to content

NEP29: Set minimum required version to NumPy 1.19+ - #1675

Merged
seisman merged 7 commits into
mainfrom
nep29/drop-numpy1.18
Dec 20, 2021
Merged

NEP29: Set minimum required version to NumPy 1.19+#1675
seisman merged 7 commits into
mainfrom
nep29/drop-numpy1.18

Conversation

@michaelgrund

@michaelgrundmichaelgrund commented Dec 19, 2021

Copy link
Copy Markdown
Member

Description of proposed changes

Following NEP29 policy where NumPy 1.18 is to be dropped on or after Dec. 22, 2021 (in a minor version increment, i.e. for PyGMT v0.6.0). Bumps minimum supported NumPy version to 1.19 in the setup.py, requirements.txt and environment.yml files. Also update installation documentation and set CI tests to run on NumPy 1.19.

xref: #1430

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@michaelgrundmichaelgrund changed the title Drop NumPy 1.18 on Dec. 22, 2021WIP Drop NumPy 1.18 on Dec. 22, 2021Dec 19, 2021
@michaelgrundmichaelgrund added the deprecation Deprecating a feature label Dec 19, 2021
@michaelgrundmichaelgrund added this to the 0.6.0 milestone Dec 19, 2021
@michaelgrundmichaelgrund changed the title WIP Drop NumPy 1.18 on Dec. 22, 2021Drop NumPy 1.18 on Dec. 22, 2021Dec 19, 2021

@seismanseisman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@michaelgrund Better to change the title to "NEP29: Set minimum required version to NumPy 1.19+" following previous PRs #1430, #1074

@seismanseisman added the final review call This PR requires final review and approval from a second reviewer label Dec 20, 2021

@weiji14weiji14 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, agree with @seisman's statement to change the title above. Also, we'll need to update the branch protection rules at https://github.com/GenericMappingTools/pygmt/settings/branches to require Python 3.7 / NumPy 1.19 before merging.

@michaelgrundmichaelgrund changed the title Drop NumPy 1.18 on Dec. 22, 2021NEP29: Set minimum required version to NumPy 1.19+Dec 20, 2021
@michaelgrund

Copy link
Copy Markdown
MemberAuthor

Looks good to me.

@michaelgrund Better to change the title to "NEP29: Set minimum required version to NumPy 1.19+" following previous PRs #1430, #1074

Thanks 😉

@michaelgrund

Copy link
Copy Markdown
MemberAuthor

Yep, agree with @seisman's statement to change the title above. Also, we'll need to update the branch protection rules at https://github.com/GenericMappingTools/pygmt/settings/branches to require Python 3.7 / NumPy 1.19 before merging.

Good to know, that needs to be done by an owner, correct @weiji14 ?

@weiji14

Copy link
Copy Markdown
Member

Yep, agree with @seisman's statement to change the title above. Also, we'll need to update the branch protection rules at https://github.com/GenericMappingTools/pygmt/settings/branches to require Python 3.7 / NumPy 1.19 before merging.

Good to know, that needs to be done by an owner, correct @weiji14 ?

Yep, just someone with admin privileges. I've done it already. Should be good to merge once status checks all pass.

@michaelgrund

Copy link
Copy Markdown
MemberAuthor

Yep, agree with @seisman's statement to change the title above. Also, we'll need to update the branch protection rules at https://github.com/GenericMappingTools/pygmt/settings/branches to require Python 3.7 / NumPy 1.19 before merging.

Good to know, that needs to be done by an owner, correct @weiji14 ?

Yep, just someone with admin privileges. I've done it already. Should be good to merge once status checks all pass.

Great, thanks 😉

@seismanseisman removed the final review call This PR requires final review and approval from a second reviewer label Dec 20, 2021
@seisman
seisman merged commit 3477ceb into mainDec 20, 2021
@seisman
seisman deleted the nep29/drop-numpy1.18 branch December 20, 2021 09:00
@weiji14weiji14 mentioned this pull request Jul 2, 2022
26 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecationDeprecating a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@michaelgrund@weiji14@seisman