Skip to content

Redesign the team gallery using sphinx-design's card directive - #1937

Merged
seisman merged 8 commits into
mainfrom
redeisgn-team-gallry
Jun 2, 2022
Merged

Redesign the team gallery using sphinx-design's card directive#1937
seisman merged 8 commits into
mainfrom
redeisgn-team-gallry

Conversation

@seisman

@seismanseisman commented May 31, 2022•
edited by weiji14
Loading

Copy link
Copy Markdown
Member

Description of proposed changes

Use sphinx-design's card directive instead of the unreadable raw HTML codes added in #1308.

The card directive can also be used in #1936.

@seismanseisman added this to the 0.7.0 milestone May 31, 2022
@seismanseisman added the documentation Improvements or additions to documentation label May 31, 2022
seisman
seisman commented May 31, 2022
View reviewed changes
Comment threaddoc/team.md Outdated
Max Jones@seisman
Update doc/team.md
8dc163b
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
weiji14
weiji14 reviewed May 31, 2022
View reviewed changes
Comment threaddoc/team.md
</div>
</div>
```
:::::{grid} 2 3 3 4

@weiji14weiji14May 31, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for the margins? Feel like the vertical spacing between cards could be increased a bit. Right now there's not much of a gap.
image
compared to https://www.pygmt.org/v0.6.1/team.html:

image

@seismanseismanJun 1, 2022

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:::::{grid} 2 3 3 4

These four numbers are the number of columns for extra-small, small, medium and large screens.

Comment threaddoc/conf.py
Comment threaddoc/conf.py
maxrjones
maxrjones reviewed May 31, 2022
View reviewed changes

@maxrjonesmaxrjones left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @seisman, so much simpler! One suggestion is to use the footer option so that the founder/maintainer labels are separated from the GitHub username (example provided as an in-line comment)

Comment threaddoc/team.md Outdated
Comment on lines +76 to +77
Maintainer
[@weiji14](https://github.com/weiji14)

@maxrjonesmaxrjonesMay 31, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Maintainer
[@weiji14](https://github.com/weiji14)
[@weiji14](https://github.com/weiji14)
+++
Maintainer
BeforeAfter

|
image | image |

@seismanseismanJun 1, 2022

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion! I've used the footer option for labels and also use sphinx-design's badge directive to highlight different roles.

image

@seisman@weiji14
Apply suggestions from code review
560b01e
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
@seisman

seisman commented Jun 1, 2022

Copy link
Copy Markdown
MemberAuthor

Here is the latest screenshot:
image

weiji14
weiji14 approved these changes Jun 1, 2022
View reviewed changes

@weiji14weiji14 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, the badges are a nice touch!

@weiji14weiji14 added the final review call This PR requires final review and approval from a second reviewer label Jun 1, 2022
maxrjones
maxrjones approved these changes Jun 1, 2022
View reviewed changes

@maxrjonesmaxrjones left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@seisman
seisman merged commit 31ccd25 into mainJun 2, 2022
@seisman
seisman deleted the redeisgn-team-gallry branch June 2, 2022 05:06
@seismanseisman removed the final review call This PR requires final review and approval from a second reviewer label Jun 2, 2022
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@seismanMax Jones
@weiji14Josh Sixsmith
Redesign the team gallery using sphinx-design's card directive (Gener…
9a7badb
…icMappingTools#1937)
Co-authored-by: Max Jones <meghanj@alum.mit.edu>
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxrjonesmaxrjonesmaxrjones approved these changes
@weiji14weiji14weiji14 approved these changes

Assignees

No one assigned

Labels

documentationImprovements or additions to documentation

Projects

None yet

Milestone

0.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@seisman@maxrjones@weiji14