Skip to content

Fix author list of PyGMT v0.7.0 - #2003

Merged
seisman merged 1 commit into
GenericMappingTools:mainfrom
yvonnefroehlich:fix-author-list-of-pygmt-v0.7.0
Jul 11, 2022
Merged

Fix author list of PyGMT v0.7.0#2003
seisman merged 1 commit into
GenericMappingTools:mainfrom
yvonnefroehlich:fix-author-list-of-pygmt-v0.7.0

Conversation

@yvonnefroehlich

Copy link
Copy Markdown
Member

Description of proposed changes

Fixes#1981 (comment) and #2002

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@maxrjonesmaxrjones left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for submitting this fix!

@seismanseisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Jul 11, 2022
@seismanseisman added this to the 0.8.0 milestone Jul 11, 2022
@seisman
seisman merged commit 1fcbc93 into GenericMappingTools:mainJul 11, 2022
@yvonnefroehlich
yvonnefroehlich deleted the fix-author-list-of-pygmt-v0.7.0 branch July 12, 2022 06:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenanceBoring but important stuff for the core devsskip-changelogSkip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@yvonnefroehlich@maxrjones@seisman