Add a workflow and Makefile target to test old GMT versions every Tuesday by seisman · Pull Request #2079 · GenericMappingTools/pygmt

seisman · 2022-08-23T13:27:00Z

Description of proposed changes

To test PyGMT with old GMT versions, a new Makefile target and a new workflow are added in this PR.

Makefile target `test_no_images`

Because the baseline images usually have slight changes for different GMT versions, it makes little sense to compare the baseline images generated by GMT 6.4 when running the tests with GMT 6.3. However, we still want to run these image-building tests to make sure they don't crash or raise errors. This is done by NOT adding the --mpl option to pytest.

New workflow "GMT Backwards Tests"

This workflow is modified from the "GMT Dev Tests" workflow. It will run when a PR is marked ready for review and will run every Tuesday.

Fixes#1991.

Reminders

Run make format and make check to make sure the code follows the style guide.
Add tests for new features or tests that would have caught the bug that you're fixing.
Add new public functions/methods/classes to doc/api/index.rst.
Write detailed docstrings for all functions/methods.
If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

/format: automatically format and lint the code
/test-gmt-dev: run full tests on the latest GMT development version

Co-authored-by: Max Jones <meghanj@alum.mit.edu>

seisman · 2022-09-09T15:29:49Z

Ping @weiji14 and @maxrjones for another round of review.

weiji14

Some suggestions to run these tests on lower versions of Python and Operating Systems.

weiji14 · 2022-09-09T15:34:53Z

@@ -0,0 +1,105 @@
+# This workflow installs PyGMT and runs tests with old GMT versions
+
+name: GMT Backward Tests


Not so sure if 'backward' is a good word, how about 'legacy' (https://en.wikipedia.org/wiki/Legacy_system)? Maybe we need to ask a native English speaker 🙂
Suggested change
name: GMT Backward Tests
name: GMT Legacy Tests

Legacy sounds good and let's wait for some inputs for native English speakers.

Done in be81f36

Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>

seisman · 2022-09-09T15:47:42Z

@@ -0,0 +1,105 @@
+# This workflow installs PyGMT and runs tests with old GMT versions


Remember to rename the workflow file if we decide to call it "GMT Legacy Tests"

Done in be81f36.

…sday (GenericMappingTools#2079) Co-authored-by: Max Jones <meghanj@alum.mit.edu> Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>

seisman changed the title ~~Add a workflow to test old GMT versions on Monday/Wednesday/Friday~~WIP Add a workflow to test old GMT versions on Monday/Wednesday/FridayAug 23, 2022

seisman marked this pull request as ready for review August 23, 2022 13:29

seisman added the maintenance Boring but important stuff for the core devs label Aug 23, 2022

seisman added this to the 0.8.0 milestone Aug 23, 2022

seisman marked this pull request as draft August 23, 2022 15:59

seisman marked this pull request as ready for review August 23, 2022 15:59

seisman changed the title ~~WIP Add a workflow to test old GMT versions on Monday/Wednesday/Friday~~WIP Add a workflow and a Makefile target to test old GMT versions on Monday/Wednesday/FridayAug 24, 2022

seisman commented Aug 24, 2022
View reviewed changes

Comment thread.github/workflows/ci_tests_backward.yaml Outdated
Comment thread.github/workflows/ci_tests_backward.yaml Outdated

seisman commented Aug 27, 2022
View reviewed changes

Comment thread.github/workflows/ci_tests_backward.yaml
Comment thread.github/workflows/ci_tests_backward.yaml

seisman commented Aug 27, 2022
View reviewed changes

Comment thread.github/workflows/ci_tests_backward.yaml
Comment thread.github/workflows/ci_tests_backward.yaml

seisman commented Aug 28, 2022
View reviewed changes

Comment thread.github/workflows/ci_tests_backward.yaml Outdated

Add a workflow to test old GMT versions on Monday/Wednesday/Friday
8d3cf45

seisman force-pushed the test-old-gmt-versions branch from 9f19869 to 8d3cf45Compare August 28, 2022 02:03

seisman changed the title ~~WIP Add a workflow and a Makefile target to test old GMT versions on Monday/Wednesday/Friday~~Add a workflow and a Makefile target to test old GMT versions on Monday/Wednesday/FridayAug 28, 2022

seisman added the needs review This PR has higher priority and needs review. label Aug 28, 2022

maxrjones reviewed Aug 28, 2022
View reviewed changes

Comment thread.github/workflows/ci_tests_backward.yaml

weiji14 reviewed Aug 28, 2022
View reviewed changes

Comment thread.github/workflows/ci_tests_backward.yaml Outdated

maxrjones reviewed Aug 28, 2022
View reviewed changes

Comment thread.github/workflows/ci_tests_backward.yaml Outdated

pull baseline image needed by tests
f303f81
Co-authored-by: Max Jones <meghanj@alum.mit.edu>

seisman changed the title ~~Add a workflow and a Makefile target to test old GMT versions on Monday/Wednesday/Friday~~Add a workflow and a Makefile target to test old GMT versions on every TuesdayAug 29, 2022

seisman commented Aug 29, 2022
View reviewed changes

Comment thread.github/workflows/ci_tests_backward.yaml Outdated
Comment thread.github/workflows/ci_tests_backward.yaml Outdated

Run the CI job on Tuesday
8e729eb

seisman commented Aug 29, 2022
View reviewed changes

Comment thread.github/workflows/ci_tests_backward.yaml Outdated

Should download test_logo.png instead
21024e2

seisman commented Aug 31, 2022
View reviewed changes

Comment thread.github/workflows/ci_tests_backward.yaml Outdated

seisman added 3 commits August 31, 2022 09:24

Update workflow description
efd3b3f

Merge branch 'main' into test-old-gmt-versions
a239ac8

Merge branch 'main' into test-old-gmt-versions
aa5f410

seisman requested review from maxrjones and weiji14 September 2, 2022 14:39

Merge branch 'main' into test-old-gmt-versions
c8fb052

weiji14 reviewed Sep 9, 2022
View reviewed changes

Test on oldest supported versions of Python and OS
fd7e209
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>

weiji14 changed the title ~~Add a workflow and a Makefile target to test old GMT versions on every Tuesday~~Add a workflow and Makefile target to test old GMT versions every TuesdaySep 9, 2022

seisman commented Sep 9, 2022
View reviewed changes

weiji14 mentioned this pull request Sep 9, 2022
pygmt.show_versions: Show GMT binary version and hide the Python interpreter path #1838
Merged

Change Backward to Legacy
be81f36

weiji14 approved these changes Sep 13, 2022
View reviewed changes

Comment thread.github/workflows/ci_tests_legacy.yaml Outdated

weiji14 added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Sep 13, 2022

willschlitzer approved these changes Sep 14, 2022
View reviewed changes

seisman commented Sep 14, 2022
View reviewed changes

Comment thread.github/workflows/ci_tests_legacy.yaml Outdated

Skip the workflow in PR
5292538

seisman merged commit 0337138 into mainSep 14, 2022

seisman deleted the test-old-gmt-versions branch September 14, 2022 15:18

seisman removed the final review call This PR requires final review and approval from a second reviewer label Sep 14, 2022

weiji14 mentioned this pull request Dec 29, 2022
load_earth_relief now can load gebco, gebcosi and synbath datasets with GMT 6.3 #2281
Merged
7 tasks

weiji14 mentioned this pull request Dec 27, 2023
Refactor test_image to plot @circuit.png instead of test_logo.png #2922
Merged
7 tasks

		@@ -0,0 +1,105 @@
		# This workflow installs PyGMT and runs tests with old GMT versions

		name: GMT Backward Tests

Uh oh!

Conversation

seisman commented Aug 23, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Makefile target test_no_images

New workflow "GMT Backwards Tests"

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

seisman commented Sep 9, 2022

Uh oh!

weiji14 left a comment

Choose a reason for hiding this comment

Uh oh!

weiji14Sep 9, 2022

Choose a reason for hiding this comment

Uh oh!

seismanSep 9, 2022

Choose a reason for hiding this comment

Uh oh!

seismanSep 13, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

seismanSep 9, 2022

Choose a reason for hiding this comment

Uh oh!

seismanSep 13, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

seisman commented Aug 23, 2022•
edited
Loading

Makefile target `test_no_images`