Uh oh!
There was an error while loading. Please reload this page.
Remove unnecessary typecheck settings for pylint - #2120
Merged
Conversation
seisman
marked this pull request as ready for review
September 17, 2022 16:02
weiji14
approved these changes
Sep 18, 2022
weiji14
left a comment
Member
There was a problem hiding this comment.
Yep, can confirm that running make lint locally doesn't throw up any errors. Tested using pylint=2.15.0 and astroid=2.12.5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
We added pylint settings
generated-members="pandas.*"in #1755 (comment) to silent annoying pylint messages. It seems recent versions of pylint no longer report these messages, so we can remove the settings.