Skip to content

clib.Session: Wrap the GMT_Get_Common API function - #2500

Merged
seisman merged 8 commits into
mainfrom
wrap-gmt-get-common
Apr 21, 2023
Merged

clib.Session: Wrap the GMT_Get_Common API function#2500
seisman merged 8 commits into
mainfrom
wrap-gmt-get-common

Conversation

@seisman

@seismanseisman commented Apr 18, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Description of proposed changes

Wrap the GMT_Get_Common API function.

Wrapping this function is a necessary step toward addressing other issues/enhancements:

@seismanseisman added this to the 0.10.0 milestone Apr 18, 2023
@seismanseisman added enhancement Improving an existing feature needs review This PR has higher priority and needs review. labels Apr 18, 2023
@seisman
seisman marked this pull request as ready for review April 18, 2023 00:56
seisman
seisman commented Apr 18, 2023
View reviewed changes
Comment threadpygmt/clib/session.py Outdated
Comment threadpygmt/clib/session.py Outdated
Comment threadpygmt/clib/session.py Outdated
seisman
seisman commented Apr 18, 2023
View reviewed changes
Comment threadpygmt/clib/session.py Outdated
@seismanseisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Apr 18, 2023
@seisman

seisman commented Apr 18, 2023

Copy link
Copy Markdown
MemberAuthor

Hopefully, this PR can get another review before I merge it @GenericMappingTools/pygmt-maintainers

weiji14
weiji14 reviewed Apr 21, 2023
View reviewed changes
Comment threadpygmt/clib/session.py Outdated
seisman
seisman commented Apr 21, 2023
View reviewed changes
Comment threadpygmt/clib/session.py Outdated
Comment threadpygmt/clib/session.py Outdated
weiji14
weiji14 reviewed Apr 21, 2023
View reviewed changes
Comment threadpygmt/clib/session.py
weiji14
weiji14 reviewed Apr 21, 2023
View reviewed changes
Comment threadpygmt/clib/session.py
- ``"a"``: geometry of the dataset (int)
- ``"b"``: return 0 if `-bi` was set and 1 if `-bo` was set (int)
- ``"f"``: return 0 if `-fi` was set and 1 if `-fo` was set (int)
- ``"h"``: whether to delete existing header records (int)

@weiji14weiji14Apr 21, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at https://docs.generic-mapping-tools.org/6.4/gmt.html#h-full, is this just checking whether -h+d was set?

@seismanseismanApr 21, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Comment threadpygmt/clib/session.py
Comment threadpygmt/clib/session.py Outdated
seismanand others added 2 commits April 21, 2023 12:01
@seisman
Add get_common to API docs
9fb950d
@seisman@weiji14
Update pygmt/clib/session.py
a894e20
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
@seismanseisman removed the final review call This PR requires final review and approval from a second reviewer label Apr 21, 2023
@seisman
seisman merged commit a840d9a into mainApr 21, 2023
@seisman
seisman deleted the wrap-gmt-get-common branch April 21, 2023 05:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelgrundmichaelgrundmichaelgrund approved these changes
@weiji14weiji14weiji14 approved these changes

Assignees

No one assigned

Labels

enhancementImproving an existing feature

Projects

None yet

Milestone

0.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@seisman@michaelgrund@weiji14