Skip to content

CI: Install geopandas using pip in the "GMT Dev Tests" workflow - #2525

Merged
seisman merged 5 commits into
mainfrom
ci-tests-dev
Jun 10, 2023
Merged

CI: Install geopandas using pip in the "GMT Dev Tests" workflow#2525
seisman merged 5 commits into
mainfrom
ci-tests-dev

Conversation

@seisman

@seismanseisman commented Apr 28, 2023

Copy link
Copy Markdown
Member

Description of proposed changes

Xref #2125 (comment) and #1290 (comment)

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman

Copy link
Copy Markdown
MemberAuthor

/test-gmt-dev

@seisman

Copy link
Copy Markdown
MemberAuthor

/test-gmt-dev

@seismanseisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels May 2, 2023
@seismanseisman added this to the 0.10.0 milestone May 2, 2023
@seisman
seisman marked this pull request as ready for review June 9, 2023 05:16
@seismanseisman changed the title CI: Improve the "Tests Dev" workflowCI: Install geopandas using pip in the "GMT Dev Tests" workflowJun 9, 2023
@seismanseisman added the needs review This PR has higher priority and needs review. label Jun 9, 2023
@@ -133,14 +132,6 @@ jobs:

# Pull baseline image data from dvc remote (DAGsHub)
- name: Pull baseline image data from dvc remote

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 134-139 and lines 141-146 are duplicated.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks like we forgot to remove these lines in #2045.

@weiji14weiji14 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks @seisman. This should allow us to catch any GDAL version conflicts between GMT and geopandas/fiona, and solve them proactively on conda-forge ahead of time!

@@ -133,14 +132,6 @@ jobs:

# Pull baseline image data from dvc remote (DAGsHub)
- name: Pull baseline image data from dvc remote

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks like we forgot to remove these lines in #2045.

@seisman
seisman merged commit 5d7eb3b into mainJun 10, 2023
@seisman
seisman deleted the ci-tests-dev branch June 10, 2023 02:28
@seismanseisman removed the needs review This PR has higher priority and needs review. label Jun 10, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenanceBoring but important stuff for the core devsskip-changelogSkip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@seisman@weiji14