Skip to content

Figure.meca: Add a test for passing event names via pandas.DataFrame - #2582

Merged
seisman merged 5 commits into
mainfrom
eventname-pandas
Jun 24, 2023
Merged

Figure.meca: Add a test for passing event names via pandas.DataFrame#2582
seisman merged 5 commits into
mainfrom
eventname-pandas

Conversation

@seisman

@seismanseisman commented Jun 22, 2023

Copy link
Copy Markdown
Member

Description of proposed changes

See #2524 for context.

The failure is caused by an upstream bug, which was already fixed in GenericMappingTools/gmt#7557.

In this PR, I renamed the old test_meca_dict_eventname test to test_meca_eventname, and add a new test following #2524. The new test passes in the "GMT Tests Dev" workflow (https://github.com/GenericMappingTools/pygmt/actions/runs/5346800096) and is skipped in the "Tests" workflow (because it crashes with GMT 6.4)

Fixes#2524

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman
seisman marked this pull request as ready for review June 22, 2023 13:54
@seismanseisman added bug Something isn't working upstream Bug or missing feature of upstream core GMT labels Jun 22, 2023
@seismanseisman added this to the 0.10.0 milestone Jun 22, 2023
@seismanseisman added maintenance Boring but important stuff for the core devs and removed bug Something isn't working labels Jun 22, 2023
@seisman

Copy link
Copy Markdown
MemberAuthor

/test-gmt-dev

@seismanseisman added the needs review This PR has higher priority and needs review. label Jun 22, 2023
@seisman

Copy link
Copy Markdown
MemberAuthor

The "DVC image diff" workflow failure will be fixed in #2583

@github-actions

Copy link
Copy Markdown
Contributor

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

StatusPath
renamedpygmt/tests/baseline/test_meca_dict_eventname.png -> pygmt/tests/baseline/test_meca_eventname.png

Image diff(s)

Details

Added images

Modified images

PathOldNew

Report last updated at commit 4208dda

@seismanseisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. final review call This PR requires final review and approval from a second reviewer labels Jun 23, 2023
@seisman
seisman merged commit dde23f1 into mainJun 24, 2023
@seisman
seisman deleted the eventname-pandas branch June 24, 2023 01:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenanceBoring but important stuff for the core devsupstreamBug or missing feature of upstream core GMT

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Figure.meca causes segmentation fault when given "event_name" via a DataFrame

3 participants

@seisman@michaelgrund@weiji14