Skip to content

Remove the unused pygmt.test() function - #2652

Merged
weiji14 merged 1 commit into
mainfrom
remove-test
Sep 1, 2023
Merged

Remove the unused pygmt.test() function#2652
weiji14 merged 1 commit into
mainfrom
remove-test

Conversation

@seisman

@seismanseisman commented Sep 1, 2023

Copy link
Copy Markdown
Member

The pygmt.test() function is not used and can be removed.

Closes#2633

@seismanseisman changed the title Remove the unused pygmt.test functionRemove the unused pygmt.test() functionSep 1, 2023
@seismanseisman added the maintenance Boring but important stuff for the core devs label Sep 1, 2023
@seismanseisman added this to the 0.10.0 milestone Sep 1, 2023
@seisman

seisman commented Sep 1, 2023

Copy link
Copy Markdown
MemberAuthor

I'm fine with merging this PR before or after the v0.10.0 release.

@michaelgrund

Copy link
Copy Markdown
Member

I'm fine with merging this PR before or after the v0.10.0 release.

Would merge it before.

@michaelgrundmichaelgrund added the final review call This PR requires final review and approval from a second reviewer label Sep 1, 2023

@weiji14weiji14 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, do we label this under maintenance or deprecation?

@seismanseisman added deprecation Deprecating a feature and removed maintenance Boring but important stuff for the core devs labels Sep 1, 2023
@seisman

Copy link
Copy Markdown
MemberAuthor

"Deprecation" makes more sense.

@weiji14
weiji14 merged commit 884e67e into mainSep 1, 2023
@weiji14
weiji14 deleted the remove-test branch September 1, 2023 06:34
weiji14 added a commit that referenced this pull request Sep 1, 2023
@yvonnefroehlichyvonnefroehlich removed the final review call This PR requires final review and approval from a second reviewer label Sep 2, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecationDeprecating a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the pygmt.test function from pygmt/__init__.py?

4 participants

@seisman@michaelgrund@weiji14@yvonnefroehlich