Uh oh!
There was an error while loading. Please reload this page.
Figure.plot: Refactor to increase code readability - #2742
Conversation
Uh oh!
There was an error while loading. Please reload this page.
michaelgrund
commented
Oct 17, 2023
Are there any further changes you wanna make @seisman ? |
seisman
commented
Oct 17, 2023
michaelgrund
commented
Oct 17, 2023
No I didn't, I was traveling the last ~4 weeks. However, just saw that Yvonne forwarded the mail to me. Will answer it later. |
seisman
commented
Mar 26, 2024
Ping @GenericMappingTools/pygmt-maintainers for final review. Will merge in 24 hours if no further comments. |
weiji14
commented
Mar 26, 2024
Did you want to update some of the type hints here, or in #2744? |
seisman
commented
Mar 27, 2024
I have some other ideas about refactoring The |
Description of proposed changes
The
Figure.plotmethod is one of the first GMT modules wrapped in PyGMT and we have kept adding more features into this method but without any refactorings.The current
Figure.plotcodes are difficult to read and maintain. This PR refactors the codes to make it easier to read by grouping the codes based on the data kind.