Skip to content

CI: Pin ghostscript to 9.54.0 in Tests and Dev Tests workflows - #2754

Merged
seisman merged 1 commit into
mainfrom
pin-gs-954
Oct 18, 2023
Merged

CI: Pin ghostscript to 9.54.0 in Tests and Dev Tests workflows#2754
seisman merged 1 commit into
mainfrom
pin-gs-954

Conversation

@seisman

@seismanseisman commented Oct 18, 2023

Copy link
Copy Markdown
Member

Description of proposed changes

The latest gs version is 10.02.0 but our baseline images were generated with gs 9.54.0, thus we will have lots of failures if we use gs 10.02.0 (see PR #2694).

We should update our gs to 10.02.0 and update all baseline images, but we decided to wait for GMT 6.5 first (#2694 (comment)) so that we don't have to update baseline images twice in a short period.

In this PR, Ghostscript is pinned to 9.54.0 for the Tests and Dev Tests workflow, so that we don't have failures due to gs 10.02.0. Other workflows are not changed because they don't care about the gs version.

We will pin Ghostscript to 10.02.0 in PR #2694.

@seismanseisman changed the title CI: Pin ghostscript to 9.54.0CI: Pin ghostscript to 9.54.0 in Tests and Dev Tests workflowsOct 18, 2023
@seismanseisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Oct 18, 2023
@seismanseisman added this to the 0.11.0 milestone Oct 18, 2023
@seismanseisman mentioned this pull request Oct 18, 2023
@seismanseisman added the needs review This PR has higher priority and needs review. label Oct 18, 2023
@seisman
seisman requested a review from a teamOctober 18, 2023 09:03

@yvonnefroehlichyvonnefroehlich left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One issue with gs version 10.02.0 is that the (semi-)transparency is (again) broken.

@seisman

Copy link
Copy Markdown
MemberAuthor

One issue with gs version 10.02.0 is that the (semi-)transparency is (again) broken.

yes, gs 10.02.0 works well with GMT 6.5.0

@seismanseisman removed the needs review This PR has higher priority and needs review. label Oct 18, 2023
@seisman
seisman merged commit ed47ce5 into mainOct 18, 2023
@seisman
seisman deleted the pin-gs-954 branch October 18, 2023 10:08
@weiji14weiji14 mentioned this pull request Oct 24, 2023
7 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenanceBoring but important stuff for the core devsskip-changelogSkip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@seisman@yvonnefroehlich