Uh oh!
There was an error while loading. Please reload this page.
Update output shape and mean values from some x2sys_cross tests - #2986
Conversation
So that the modified tracks won't be used in other test functions, causing tests to fail.
Small changes to the number of output rows, and the mean value of the z_X and z_M/z_1/z_2 columns.
| newtracks = copy.deepcopy(x=tracks) | ||
| newtracks[0].loc[newtracks[0]["z"] < -15, "z"] = np.nan # set some NaN values | ||
| output = x2sys_cross(tracks=newtracks, tag=tag, coe="i") |
| output = x2sys_cross(tracks=["@tut_ship.xyz"], tag=tag, coe="i") | ||
| assert isinstance(output, pd.DataFrame) | ||
| assert output.shape == (14294, 12) | ||
| assert output.shape == (14338, 12) |
There was a problem hiding this comment.
Still a little unsure why GMT 6.5.0's x2sys_cross returns more rows than GMT 6.4.0. Might need to investigate.
weiji14
commented
Jan 16, 2024
Haven't got time to check whether the change in output shape from |
seisman
commented
Jan 27, 2024
The |
Description of proposed changes
Small changes to the number of output rows, and the mean value of the z_X and z_M/z_1/z_2 columns.
Also for
test_x2sys_cross_input_dataframe_with_nan, a deep copy of thetracks: list[pd.DataFrame]object is now made before NaN values are set, to avoid some test flakiness.Addresses #2961 (comment)
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash command is:
/format: automatically format and lint the code