Skip to content

Make all functions/methods have consistent behavior for table output - #3092

Closed
seisman wants to merge 19 commits into
mainfrom
table-outputs
Closed

Make all functions/methods have consistent behavior for table output#3092
seisman wants to merge 19 commits into
mainfrom
table-outputs

Conversation

@seisman

@seismanseisman commented Mar 7, 2024

Copy link
Copy Markdown
Member

This PR shows how the return_table method added in PR #3083 can simplify the codes.

Wrappers that still use temporary files:

  • info
  • grdinfo
  • which
  • x2sys_cross

@seismanseisman added the run/benchmark Trigger the benchmark workflow in PRs label Mar 7, 2024
@codspeed-hq

codspeed-hqBot commented Mar 7, 2024

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #3092 will degrade performances by 90.41%

⚠️ No base runs were found

Falling back to comparing table-outputs (466594b) with main (28e3513)

Summary

⚡ 1 improvements
❌ 12 regressions
✅ 85 untouched benchmarks

⚠️Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmarkmaintable-outputsChange
test_blockmean_input_xyz413.4 ms365.6 ms+13.08%
test_contour_matrix[DataFrame]90.7 ms281.8 ms-67.81%
test_contour_matrix[Dataset]103.9 ms294.9 ms-64.76%
test_contour_matrix[array]88.5 ms279.6 ms-68.34%
test_filter1d_format199.8 ms517.8 ms-61.42%
test_grd2xyz43.1 ms229.2 ms-81.2%
test_grdtrack_input_dataframe_and_dataarray44 ms233.4 ms-81.16%
test_grdvolume_no_outgrid41.7 ms294.4 ms-85.82%
test_project_input_matrix[DataFrame]41.7 ms422.2 ms-90.13%
test_project_input_matrix[Dataset]50.8 ms431.3 ms-88.22%
test_project_input_matrix[array]40.3 ms420.9 ms-90.41%
test_select_input_dataframe187.6 ms374.3 ms-49.88%
test_delaunay_triples_input_xyz169.2 ms357.3 ms-52.65%

@seisman
seismanforce-pushed the table-outputs branch 3 times, most recently from 24b967a to 5f1a74fCompareMarch 7, 2024 05:41
Base automatically changed from clib/return_table to mainMarch 11, 2024 11:17
@seismanseisman closed this Mar 14, 2024
@seisman
seisman deleted the table-outputs branch March 14, 2024 00:53
@seismanseisman removed the run/benchmark Trigger the benchmark workflow in PRs label Mar 14, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@seisman