Skip to content

Wrap GMT's standard data type GMT_CUBE for cubes and support reading/writing cubes - #3150

Open
seisman wants to merge 36 commits into
mainfrom
datatypes/gmtcube
Open

Wrap GMT's standard data type GMT_CUBE for cubes and support reading/writing cubes#3150
seisman wants to merge 36 commits into
mainfrom
datatypes/gmtcube

Conversation

@seisman

@seismanseisman commented Mar 31, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Similar to #3338 and #3128, but for wrapping GMT_CUBE.

Main changes in this PR:

  • Wrap GMT's standard data type GMT_CUBE
  • Implement the to_xarray method
  • Let low-level functions (e.g., read_data/write_data) support cubes
  • Extend the xarray backend to support cubes (i.e., xr.open_dataarray("xxx.cube", engine="gmt", kind="cube")

Known issues:

  • It seems we can't use lib.call_module("read", "@cube.nc out.nc -Tu") for cubes. The similar command works well for grids and images. It's likely an upstream bug.

Base automatically changed from gmtgrid/parser to mainApril 1, 2024 05:56
michaelgrund
michaelgrund reviewed Apr 2, 2024
View reviewed changes
Comment threadpygmt/datatypes/cube.py Outdated
@seismanseisman mentioned this pull request Apr 19, 2024
Closed
@seismanseisman added the feature Brand new feature label Jul 27, 2024
@seismanseisman mentioned this pull request Aug 5, 2024
Merged
@seismanseisman added this to the 0.14.0 milestone Aug 5, 2024
@seismanseisman removed this from the 0.14.0 milestone Sep 5, 2024
@seismanseisman mentioned this pull request Sep 29, 2024
Merged
@weiji14weiji14 mentioned this pull request Sep 30, 2024
Open
@seismanseisman self-assigned this Oct 30, 2024
@seismanseisman mentioned this pull request Apr 17, 2025
Draft
7 tasks
@seismanseisman changed the title Wrap GMT's standard data type GMT_CUBE for cubesWrap GMT's standard data type GMT_CUBE for cubes and support reading/writing cubesAug 25, 2026
@seismanseisman added this to the 0.20.0 milestone Aug 25, 2026
@seisman
seisman marked this pull request as ready for review August 25, 2026 16:54
@seismanseisman added the needs review This PR has higher priority and needs review. label Aug 25, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelgrundmichaelgrundmichaelgrund left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@seismanseisman

Labels

featureBrand new featureneeds reviewThis PR has higher priority and needs review.

Projects

None yet

Milestone

0.20.0

Development

Successfully merging this pull request may close these issues.

2 participants

@seisman@michaelgrund