Skip to content

Remove sequence_space converter from kwargs_to_string - #3183

Merged
weiji14 merged 1 commit into
mainfrom
sequence_space
Apr 21, 2024
Merged

Remove sequence_space converter from kwargs_to_string#3183
weiji14 merged 1 commit into
mainfrom
sequence_space

Conversation

@seisman

@seismanseisman commented Apr 20, 2024

Copy link
Copy Markdown
Member

Description of proposed changes

Remove sequence_space converter from @kwargs_to_string, which is no longer needed after #3132. For reference, it was initially added in #325.

Address #3132 (comment).

@seismanseisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Apr 20, 2024
@seismanseisman added this to the 0.12.0 milestone Apr 20, 2024
@seismanseisman added the needs review This PR has higher priority and needs review. label Apr 20, 2024
@seismanseisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Apr 21, 2024
@weiji14weiji14 added deprecation Deprecating a feature and removed maintenance Boring but important stuff for the core devs labels Apr 21, 2024
@weiji14
weiji14 merged commit d844fd1 into mainApr 21, 2024
@weiji14
weiji14 deleted the sequence_space branch April 21, 2024 21:41
@seismanseisman removed the final review call This PR requires final review and approval from a second reviewer label Apr 21, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecationDeprecating a featureskip-changelogSkip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@seisman@michaelgrund@weiji14