Uh oh!
There was an error while loading. Please reload this page.
Disable Windows CI builds before PR #313 is merged - #320
Merged
Conversation
weiji14
requested changes
Aug 21, 2019
weiji14
left a comment
Member
There was a problem hiding this comment.
Only a small cosmetic change to the Shields.io badge, otherwise looks fine.
Uh oh!
There was an error while loading. Please reload this page.
Co-Authored-By: Wei Ji <23487320+weiji14@users.noreply.github.com>
weiji14
reviewed
Aug 22, 2019
weiji14
left a comment
Member
There was a problem hiding this comment.
There's an extra whitespace that slipped in... Also not sure what's up with miniconda, Mac Python 3.6 builds failing https://dev.azure.com/GenericMappingTools/PyGMT/_build/results?buildId=2172&view=logs&jobId=5d114cdd-65bd-5ce6-b5d2-d3717f4f43b7&taskId=dac18a8e-ef5a-5fdd-edf3-b04e14eaafa9&lineStart=277&lineEnd=278&colStart=1&colEnd=1
| :alt: Travis CI build status | ||
| :target: https://travis-ci.org/GenericMappingTools/pygmt | ||
| .. image:: https://img.shields.io/azure-devops/build/GenericMappingTools/7682ad4e-76bb-4775-849e-7c4f8dce4e1a/3/master.svg?label=Azure&style=flat-square | ||
| .. image:: https://img.shields.io/azure-devops/build/GenericMappingTools/7682ad4e-76bb-4775-849e-7c4f8dce4e1a/3/master.svg?label=Mac|Windows&style=flat-square |
Member
There was a problem hiding this comment.
Oops, extra space in the front... Maybe don't use the suggested changes.
Suggested change
| .. image:: https://img.shields.io/azure-devops/build/GenericMappingTools/7682ad4e-76bb-4775-849e-7c4f8dce4e1a/3/master.svg?label=Mac|Windows&style=flat-square | |
| .. image:: https://img.shields.io/azure-devops/build/GenericMappingTools/7682ad4e-76bb-4775-849e-7c4f8dce4e1a/3/master.svg?label=Mac|Windows&style=flat-square |
seisman
commented
Aug 22, 2019
MemberAuthor
All the tests pass now. |
seisman
commented
Aug 22, 2019
MemberAuthor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.