Skip to content

CI: Set PROJ_LIB in the Benchmarks workflow to fix the proj_create_from_database error - #3241

Merged
seisman merged 3 commits into
mainfrom
ci/benchmarks-proj
May 12, 2024
Merged

CI: Set PROJ_LIB in the Benchmarks workflow to fix the proj_create_from_database error#3241
seisman merged 3 commits into
mainfrom
ci/benchmarks-proj

Conversation

@seisman

@seismanseisman commented May 11, 2024

Copy link
Copy Markdown
Member

Description of proposed changes

In the "Benchmarks" workflow (e.g., https://github.com/GenericMappingTools/pygmt/actions/runs/9001470390/job/24727777928), we can see an error like:

 ERROR 1: PROJ: proj_create_from_database: Open of /usr/share/miniconda/share/proj failed

which is not seen in the Tests workflow (e.g., https://github.com/GenericMappingTools/pygmt/actions/runs/9039830454/job/24843235152).

Currently, the "Benchmarks" workflow is not affected by the error and still passes, but it fails in #3193. So, we should fix the error.

It's unclear what's happening exactly, but the solution is simple. We just need to set the PROJ_LIB environment variable. xref: https://gis.stackexchange.com/questions/364421/how-to-make-proj-work-via-anaconda-in-google-colab/370360#370360

After this patch, the error disappears. See https://github.com/GenericMappingTools/pygmt/actions/runs/9039893228/job/24843381919

@seismanseisman added run/benchmark Trigger the benchmark workflow in PRs maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog needs review This PR has higher priority and needs review. labels May 11, 2024
@seismanseisman added this to the 0.13.0 milestone May 11, 2024
@seisman
seisman requested a review from weiji14May 11, 2024 08:30
@codspeed-hq

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #3241 will degrade performances by 11.31%

Comparing ci/benchmarks-proj (7e5b7da) with main (4fbf32f)

Summary

❌ 1 regressions
✅ 98 untouched benchmarks

⚠️Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmarkmainci/benchmarks-projChange
test_grdsample_dataarray_out48.7 ms54.9 ms-11.31%

@seisman
seisman merged commit 9d0c02e into mainMay 12, 2024
@seisman
seisman deleted the ci/benchmarks-proj branch May 12, 2024 23:17
@seismanseisman removed needs review This PR has higher priority and needs review. run/benchmark Trigger the benchmark workflow in PRs labels May 12, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenanceBoring but important stuff for the core devsskip-changelogSkip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@seisman