Uh oh!
There was an error while loading. Please reload this page.
Refactor clib to avoid checking GMT version repeatedly and only check once when loading the GMT library - #3254
Merged
Merged
Conversation
seisman
marked this pull request as draft
May 16, 2024 16:34
seismanforce-pushed
the
clib/check-version
branch
4 times, most recently
from
May 21, 2024 05:31
d2ef07d to
90ac95dCompareseisman
commented
May 21, 2024
Uh oh!
There was an error while loading. Please reload this page.
seismanforce-pushed
the
clib/check-version
branch
5 times, most recently
from
May 29, 2024 05:38
07b06ac to
b42b758Compareseismanforce-pushed
the
clib/check-version
branch
2 times, most recently
from
July 24, 2024 09:35
833efb4 to
9907af7Compareseisman
marked this pull request as ready for review
July 24, 2024 09:37
weiji14
reviewed
Jul 29, 2024
| func.restype = ctypes.c_float | ||
| major, minor, patch = ctypes.c_uint(0), ctypes.c_uint(0), ctypes.c_uint(0) | ||
| func(None, major, minor, patch) | ||
| return f"{major.value}.{minor.value}.{patch.value}" |
Member
There was a problem hiding this comment.
Thoughts on returning an instance of packaging.version.Version instead of a str?
MemberAuthor
There was a problem hiding this comment.
but __gmt_version__ should be a string.
Member
There was a problem hiding this comment.
Mm ok, could also do str(get_gmt_version()), but ok to just return a string itself. Just thought it could simplify some of the test code.
weiji14
approved these changes
Jul 29, 2024
weiji14
left a comment
Member
There was a problem hiding this comment.
Just two tiny suggestions. Having the code spread across clib/__init__.py, clib/loading.py and clib/session.py is a little confusing, but seems to make sense after going through it.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
In the
Session.__enter__method, we check if the GMT library version is equal to or newer than the required version. This special method is called when entering the context manager, i.e.,with Session() as lib. So it means we're repeatedly checking the GMT version.This PR refactors the clib codes to check the GMT version only once when loading the GMT library.
I expect to see some performance improvements
but the benchmarks say no. So I believe the performance improvement should be very little.https://codspeed.io/GenericMappingTools/pygmt/branches/clib/check-version show an average 2% performance improvement.