Uh oh!
There was an error while loading. Please reload this page.
Session.virtualfile_in: Deprecate parameter 'required_z'. Use 'mincols' instead (will be removed in v0.20.0) - #3369
Merged
Merged
Conversation
seismanforce-pushed
the
refactor/virtualfile_in
branch
2 times, most recently
from
August 4, 2024 11:01
f1e6aca to
9e78da0Compareseismanforce-pushed
the
refactor/virtualfile_in
branch
2 times, most recently
from
August 4, 2024 12:39
2a1db22 to
b33476cCompareseismanforce-pushed
the
refactor/data_kind
branch
from
October 3, 2024 09:21
bca59f5 to
808755dCompareseismanforce-pushed
the
refactor/virtualfile_in
branch
from
March 5, 2025 08:06
d7ca533 to
feddd9cCompareseismanforce-pushed
the
refactor/virtualfile_in
branch
from
March 5, 2025 08:12
feddd9c to
2d55e5aCompare6 tasks
seisman
commented
Mar 10, 2025
| GMTInvalidInput | ||
| If the data input is not valid. | ||
| """ | ||
| required_z = ncols >= 3 |
MemberAuthor
There was a problem hiding this comment.
This is just a temporary fix. Will refactor _validate_data_input in #3818.
seisman
marked this pull request as ready for review
March 26, 2025 09:19
seisman
marked this pull request as draft
April 2, 2025 04:13
seisman
marked this pull request as ready for review
April 15, 2025 02:53
weiji14
approved these changes
Apr 27, 2025
weiji14
left a comment
Member
There was a problem hiding this comment.
Debating on whether to call the parameter mincols instead of ncols, but leave it up to you to decide.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #3836.
This PR removes the
required_zparameter and add a new parametermincols.required_z=Truemeansmincols=3.