Skip to content

clib.conversion: Add type hints and improve docstrings for dataarray_to_matrix, vectors_to_arrays, and array_to_datetime - #3496

Merged
seisman merged 6 commits into
mainfrom
typing/dataarray-to-matrix
Oct 11, 2024
Merged

clib.conversion: Add type hints and improve docstrings for dataarray_to_matrix, vectors_to_arrays, and array_to_datetime#3496
seisman merged 6 commits into
mainfrom
typing/dataarray-to-matrix

Conversation

@seisman

Copy link
Copy Markdown
Member

No code changes, just add type hints and improve docstrings.

@seismanseisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog needs review This PR has higher priority and needs review. typing Type hints and static type checking labels Oct 9, 2024
@seismanseisman added this to the 0.14.0 milestone Oct 9, 2024
@seisman
seismanforce-pushed the typing/dataarray-to-matrix branch from 2ef58f2 to f154010CompareOctober 9, 2024 07:47
@seisman
seismanforce-pushed the typing/dataarray-to-matrix branch from f154010 to 49c2c52CompareOctober 9, 2024 08:20
@seismanseisman changed the title clib.conversion.dataarray_to_matrix: Add type hints and improve docstringsclib.conversion: Add type hints and improve docstrings for dataarray_to_matrix, vectors_to_arrays, and array_to_datetimeOct 9, 2024
@seismanseisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Oct 11, 2024
Comment threadpygmt/clib/conversion.py Outdated
Co-authored-by: Michael Grund <23025878+michaelgrund@users.noreply.github.com>
@seisman
seisman merged commit 96b1263 into mainOct 11, 2024
@seisman
seisman deleted the typing/dataarray-to-matrix branch October 11, 2024 06:29
@seismanseisman removed the final review call This PR requires final review and approval from a second reviewer label Oct 14, 2024
seisman added a commit that referenced this pull request Oct 16, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenanceBoring but important stuff for the core devsskip-changelogSkip adding Pull Request to changelogtypingType hints and static type checking

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@seisman@michaelgrund