Skip to content

Split tests related to virtualfiles into multiple test files - #3512

Merged
seisman merged 6 commits into
mainfrom
tests/split
Oct 14, 2024
Merged

Split tests related to virtualfiles into multiple test files#3512
seisman merged 6 commits into
mainfrom
tests/split

Conversation

@seisman

@seismanseisman commented Oct 14, 2024

Copy link
Copy Markdown
Member

Description of proposed changes

Split pygmt/tests/test_clib_virtualfiles.py into:

  • pygmt/tests/test_clib_inquire_virtualfile.py
  • pygmt/tests/test_clib_virtualfile_from_matrix.py
  • pygmt/tests/test_clib_virtualfile_from_stringio.py
  • pygmt/tests/test_clib_virtualfile_from_vectors.py
  • pygmt/tests/test_clib_virtualfile_in.py

Note that open_virtualfile tests remain in test_clib_virtualfiles.py.

Addresses #3351 (comment).

Previous split at #2784.

@seismanseisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog final review call This PR requires final review and approval from a second reviewer labels Oct 14, 2024
@seismanseisman added this to the 0.14.0 milestone Oct 14, 2024
@weiji14weiji14 added the run/benchmark Trigger the benchmark workflow in PRs label Oct 14, 2024
@codspeed-hq

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #3512 will not alter performance

Comparing tests/split (4ce69d8) with main (f224563)

Summary

✅ 93 untouched benchmarks

🆕 8 new benchmarks
⁉️ 8 dropped benchmarks

⚠️Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmarkmaintests/splitChange
🆕test_open_virtualfileN/A62.7 msN/A
🆕test_virtualfile_from_matrixN/A63.3 msN/A
🆕test_virtualfile_from_vectorsN/A63.9 msN/A
🆕test_virtualfile_from_vectors_one_string_or_object_column[object]N/A8.4 msN/A
🆕test_virtualfile_from_vectors_one_string_or_object_column[str]N/A8.4 msN/A
🆕test_virtualfile_in_required_z_matrix[DataFrame-vector]N/A9.6 msN/A
🆕test_virtualfile_in_required_z_matrix[Dataset-vector]N/A11.9 msN/A
🆕test_virtualfile_in_required_z_matrix[array-matrix]N/A9 msN/A
⁉️test_virtual_file63 msN/AN/A
⁉️test_virtualfile_from_matrix63.3 msN/AN/A
⁉️test_virtualfile_from_vectors64 msN/AN/A
⁉️test_virtualfile_from_vectors_one_string_or_object_column[object]8.4 msN/AN/A
⁉️test_virtualfile_from_vectors_one_string_or_object_column[str]8.4 msN/AN/A
⁉️test_virtualfile_in_required_z_matrix[DataFrame-vector]9.6 msN/AN/A
⁉️test_virtualfile_in_required_z_matrix[Dataset-vector]11.9 msN/AN/A
⁉️test_virtualfile_in_required_z_matrix[array-matrix]9 msN/AN/A

@weiji14weiji14 removed the run/benchmark Trigger the benchmark workflow in PRs label Oct 14, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we keep test_inquire_virtualfile in test_clib_virtualfiles.py? I'd like to keep that file so that we can still look back at the git history more easily.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I've renamed test_clib_open_virtualfiles.py back to test_clib_virtualfiles.py.

For inquire_virtualfile, I plan to add more tests about GMT_IN in the future.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, that works too, thanks!

@seismanseisman removed the final review call This PR requires final review and approval from a second reviewer label Oct 14, 2024
@seisman
seisman merged commit 86c9b2d into mainOct 14, 2024
@seisman
seisman deleted the tests/split branch October 14, 2024 23:02
weiji14 added a commit that referenced this pull request Nov 15, 2024
The test_virtualfile_from_vectors_one_string_or_object_column unit test was moved to test_clib_virtualfile_from_vectors.py. Xref #3512
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenanceBoring but important stuff for the core devsskip-changelogSkip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@seisman@michaelgrund@weiji14