Uh oh!
There was an error while loading. Please reload this page.
Fix the _validate_data_input function after refactoring data_kind - #3541
Merged
Conversation
seismanforce-pushed
the
fix/validate-data-input
branch
from
October 21, 2024 09:39
1f6cdcb to
8f21815Comparemichaelgrund
approved these changes
Oct 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
After #3351, only 2-D numpy array are recognized as "matrix". Other objects like pandas.DataFrame are recognized as "vectors" instead.
So we have to update the
_validate_data_input.