Uh oh!
There was an error while loading. Please reload this page.
Figure.savefig: Clarify that 'transparent' also works for the PNG file associated with the KML format - #3579
Merged
Merged
Conversation
…e associated with the KML format
seismanforce-pushed
the
savefig/transparency
branch
from
November 5, 2024 03:43
d0a0cfb to
94f9f14Compareseisman
commented
Nov 5, 2024
| msg = f"Transparency unavailable for '{ext}', only for png." | ||
| msg = f"Unknown extension '.{ext}'." | ||
| raise GMTInvalidInput(msg) | ||
| fmt = fmt.upper() |
MemberAuthor
There was a problem hiding this comment.
Changes to something like "png": "G" if transparent is True else "g" at line #210.
| raise GMTInvalidInput(msg) | ||
| fmt = fmt.upper() | ||
| if transparent and ext not in {"kml", "png"}: |
MemberAuthor
There was a problem hiding this comment.
Instead of checking fmt != "g", here we explicitly check if ext not in {"kml", "png"}
michaelgrund
approved these changes
Nov 5, 2024
seisman added a commit
that referenced
this pull request
Nov 6, 2024
…e associated with the KML format (#3579)
seisman added a commit
that referenced
this pull request
Nov 18, 2024
…e associated with the KML format (#3579)
seisman added a commit
that referenced
this pull request
Nov 18, 2024
…e associated with the KML format (#3579)
seisman added a commit
that referenced
this pull request
Nov 19, 2024
…e associated with the KML format (#3579)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
transparentworks for.kmlformat and add a test for it