Skip to content

Improve the workarounds for handling pandas nullable dtypes in pandas<=2.1 - #3596

Merged
seisman merged 2 commits into
mainfrom
pandas-2.1
Dec 12, 2024
Merged

Improve the workarounds for handling pandas nullable dtypes in pandas<=2.1#3596
seisman merged 2 commits into
mainfrom
pandas-2.1

Conversation

@seisman

Copy link
Copy Markdown
Member

Description of proposed changes

This PR is cherry-picked from #3584. See that PR for context. More tests will be added in that PR too.

This PR is an improved version of PR #3505.

Labeling this PR as "bug" and we will merge the two entries for PR #3505 and this PR when we drafting the release changelog.

@seismanseisman added bug Something isn't working needs review This PR has higher priority and needs review. labels Nov 7, 2024
@seismanseisman added this to the 0.14.0 milestone Nov 7, 2024
@seismanseisman removed the needs review This PR has higher priority and needs review. label Nov 7, 2024
Comment threadpygmt/clib/conversion.py Outdated
@seisman
seisman marked this pull request as draft November 8, 2024 02:49
@seisman
seisman marked this pull request as ready for review November 9, 2024 14:20
@seismanseisman added needs review This PR has higher priority and needs review. and removed needs review This PR has higher priority and needs review. labels Nov 9, 2024
@seisman
seisman marked this pull request as draft November 10, 2024 07:25
@seisman

Copy link
Copy Markdown
MemberAuthor

Please review the changes in #3584 first. I'll cherry-pick changes in that PR to this PR later.

@seismanseisman added the needs review This PR has higher priority and needs review. label Dec 9, 2024
@seisman
seisman marked this pull request as ready for review December 12, 2024 01:28
@seismanseisman removed the needs review This PR has higher priority and needs review. label Dec 12, 2024
@seisman
seisman merged commit 4d9f897 into mainDec 12, 2024
@seisman
seisman deleted the pandas-2.1 branch December 12, 2024 01:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugSomething isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@seisman@yvonnefroehlich