Skip to content

clib.conversion._to_numpy: Use pytest.mark.skipif to skip string_view type test for pyarrow < 16 - #3660

Merged
weiji14 merged 3 commits into
mainfrom
to_numpy/string_view
Dec 1, 2024
Merged

clib.conversion._to_numpy: Use pytest.mark.skipif to skip string_view type test for pyarrow < 16#3660
weiji14 merged 3 commits into
mainfrom
to_numpy/string_view

Conversation

@seisman

@seismanseisman commented Nov 28, 2024

Copy link
Copy Markdown
Member

Cherry-picking 4733bda from PR #3639, but use the dummy pa class when pyarrow is not installed.

PyArrow string_view was added since pyarrow v16 (apache/arrow#39652).

@seismanseisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog needs review This PR has higher priority and needs review. labels Nov 28, 2024
@seismanseisman added this to the 0.14.0 milestone Nov 28, 2024
@seisman
seisman requested a review from weiji14November 28, 2024 16:12
@michaelgrundmichaelgrund added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Nov 29, 2024
@seisman

Copy link
Copy Markdown
MemberAuthor

Ping @weiji14 for.final review.

@weiji14
weiji14 merged commit 8cfdb5b into mainDec 1, 2024
@weiji14
weiji14 deleted the to_numpy/string_view branch December 1, 2024 22:12
@seismanseisman removed the final review call This PR requires final review and approval from a second reviewer label Dec 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenanceBoring but important stuff for the core devsskip-changelogSkip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@seisman@michaelgrund@weiji14