Uh oh!
There was an error while loading. Please reload this page.
Reorganize GMTDataArrayAccessor to the pygmt.xarray module - #3928
Merged
Conversation
weiji14
commented
Apr 27, 2025
Member
Probably should also rename |
seisman
commented
Apr 28, 2025
MemberAuthor
Done |
weiji14
approved these changes
Apr 28, 2025
weiji14
left a comment
Member
There was a problem hiding this comment.
Oh, and rename the test function names from def test_accessor_* to def test_xarray_accessor_*? Not compulsory though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address #3919 (comment).
This PR moves the
pygmt/accessors.pytopygmt/xarray/accessor.py[singular vs plural] and also movesGMTDataArrayAccessorto the "Xarray Integration" section in the docs.Preview: https://pygmt-dev--3928.org.readthedocs.build/en/3928/api/index.html#xarray-integration