Uh oh!
There was an error while loading. Please reload this page.
Mark test_binstats_quantile as xfail in the GMT Legacy Tests workflow - #4087
Merged
Conversation
weiji14
commented
Sep 15, 2025
Uh oh!
There was an error while loading. Please reload this page.
Comment on lines
+74
to
+81
| if Version(__gmt_version__) > Version("6.4.0"): | ||
| npt.assert_allclose(temp_grid.min(), 53) | ||
| npt.assert_allclose(temp_grid.median(), 543664.5) | ||
| npt.assert_allclose(temp_grid.mean(), 1661363.6) | ||
| else: # TODO(GMT>=6.5.0): Remove if-condition with different min/median/mean values | ||
| npt.assert_allclose(temp_grid.min(), 0) | ||
| npt.assert_allclose(temp_grid.median(), 330700.0) | ||
| npt.assert_allclose(temp_grid.mean(), 1459889.1) |
MemberAuthor
There was a problem hiding this comment.
Unsure which values are the correct ones. Do we want to check in upstream GMT on what might have changed binstat from GMT 6.4 to 6.5?
MemberAuthor
There was a problem hiding this comment.
Thanks for the reminder, forgot about that thread! Have changed to an xfail in commit 1dc2e42
This reverts commit b37898b.
weiji14
marked this pull request as ready for review
September 16, 2025 03:49
seisman
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
The
test_binstats_quantiletest (introduced in #3012) is failing on the legacy CI tests.Trying to see if it's due to xarray/pandas/numpy or using old version of GMT 6.4Edit: seems to be that GMT 6.4 gives different results to GMT 6.5+, most likely due to changes in GenericMappingTools/gmt#8243Traceback from https://github.com/GenericMappingTools/pygmt/actions/runs/16895808645/job/47865247702#step:6:1098
Output of pygmt.show_versions() from CI:
Patches #3012
Preview:
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash command is:
/format: automatically format and lint the code