Skip to content

Figure.subplot / Figure.set_panel: Deprecate parameters autolabel / fixedlabel to tag (Will be removed in v0.21.0) - #4275

Closed
yvonnefroehlich wants to merge 5 commits into
mainfrom
deprecate-subplot-label
Closed

Figure.subplot / Figure.set_panel: Deprecate parameters autolabel / fixedlabel to tag (Will be removed in v0.21.0)#4275
yvonnefroehlich wants to merge 5 commits into
mainfrom
deprecate-subplot-label

Conversation

@yvonnefroehlich

@yvonnefroehlichyvonnefroehlich commented Dec 12, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Description of proposed changes

Use underscores between words in parameter names; related to #2014.

See #4313, #4313 (comment).

Preview:

Guidelines

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash command is:

  • /format: automatically format and lint the code

@yvonnefroehlichyvonnefroehlich added this to the 0.18.0 milestone Dec 12, 2025
@yvonnefroehlichyvonnefroehlich self-assigned this Dec 12, 2025
@yvonnefroehlichyvonnefroehlich added the deprecation Deprecating a feature label Dec 12, 2025
@yvonnefroehlichyvonnefroehlich changed the title Figur.subplot / Figure.set_panel: Deprecate autolabel / fixedlabel to auto_label / fixed_label (Will be removed in v0.20.0)Figure.subplot / Figure.set_panel: Deprecate autolabel / fixedlabel to auto_label / fixed_label (Will be removed in v0.20.0)Dec 12, 2025
@yvonnefroehlichyvonnefroehlich changed the title Figure.subplot / Figure.set_panel: Deprecate autolabel / fixedlabel to auto_label / fixed_label (Will be removed in v0.20.0)Figure.subplot / Figure.set_panel: Deprecate parameters autolabel / fixedlabel to auto_label / fixed_label (Will be removed in v0.20.0)Dec 12, 2025
yvonnefroehlich
yvonnefroehlich commented Dec 12, 2025
View reviewed changes
Comment threadpygmt/tests/test_subplot.py Outdated
@seisman

seisman commented Dec 13, 2025

Copy link
Copy Markdown
Member

The autolabel parameter takes non-Pythonic arguments. Need more discussions before renaming.

@yvonnefroehlich
yvonnefroehlich marked this pull request as draft December 13, 2025 06:44
@yvonnefroehlichyvonnefroehlich mentioned this pull request Dec 16, 2025
Closed
@seismanseisman removed this from the 0.18.0 milestone Dec 18, 2025
@yvonnefroehlichyvonnefroehlich changed the title Figure.subplot / Figure.set_panel: Deprecate parameters autolabel / fixedlabel to auto_label / fixed_label (Will be removed in v0.20.0)Figure.subplot / Figure.set_panel: Deprecate parameters autolabel / fixedlabel to tag (Will be removed in v0.21.0)Feb 6, 2026
@seisman

seisman commented Feb 7, 2026

Copy link
Copy Markdown
Member

As discussed in #4313 (comment), we'll use tag for both parameters. So, closing the PR.

@seismanseisman closed this Feb 7, 2026
@seismanseisman added this to the 0.19.0 milestone Feb 7, 2026
@seismanseisman added the duplicate This issue or pull request already exists label Feb 7, 2026
@seisman
seisman deleted the deprecate-subplot-label branch February 7, 2026 05:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@yvonnefroehlichyvonnefroehlich

Labels

deprecationDeprecating a featureduplicateThis issue or pull request already exists

Projects

None yet

Milestone

0.19.0

Development

Successfully merging this pull request may close these issues.

2 participants

@yvonnefroehlich@seisman