BREAKING: Raise GMTParameterError exception for conflicts_with parameters. Previously raise GMTInvalidInput by Chuan1937 · Pull Request #4387 · GenericMappingTools/pygmt

Chuan1937 · 2026-02-04T04:16:02Z

Add GMTParameterError: conflicts_with

@seisman
This is the fourth PR of #4003

Error types	Preferred Parameter Name	Alternative Parameter Names	Error Message Template
Required	`required`	`must_have`, `needed`	`Missing required parameter: '{param}'` `Missing required parameters: '{a}', '{b}'`
At least one is required	`at_least_one`	`need_one_of`, , , any_of``one_of``required_any	`Missing required parameters: '{a}', '{b}', '{c}'. Must specify at least one.` `Must specify at least one of the parameters: '{a}', '{b}', '{c}'`
At most one	`at_most_one`	`mutually_exclusive`	`Mutually exclusive parameters: '{a}', '{b}', '{c}'. Specify at most one`
Conflicting	`conflicts_with`	`conflicts`, `incompatible_with`	`Conflicting parameters: '{a}' cannot be used with '{b}', '{c}'`

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

seisman · 2026-02-04T09:43:27Z

Please also update pygmt/alias.py.

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

…ature/conflict

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

seisman · 2026-02-06T06:23:50Z

This PR is almost in good shape. The failing tests are actually because set in Python is not order-guaranteed, so using set is likely a bad idea.

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

Chuan1937 · 2026-02-06T08:30:19Z

This PR is almost in good shape. The failing tests are actually because set in Python is not order-guaranteed, so using set is likely a bad idea.

Indeed, I have been making corrections along the wrong path. Thank you for your corrections.

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

Chuan1937and others added 3 commits February 4, 2026 12:14

add conflict parameter for GMTParameterError
0105bb6

update test file
d8c15e7

Merge branch 'main' into feature/conflict
7b6d102

seisman reviewed Feb 4, 2026
View reviewed changes

Comment threadpygmt/src/_common.py Outdated
Comment threadpygmt/src/_common.py Outdated
Comment threadpygmt/src/grdview.py Outdated

Xingchen Heand others added 4 commits February 4, 2026 17:21

Update pygmt/src/_common.py
406eb7b
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

Update pygmt/src/_common.py
b28747d
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

Update pygmt/src/grdview.py
c15f3f3
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

fix check
25bad04

Chuan1937 requested a review from seisman February 4, 2026 09:26

seisman reviewed Feb 4, 2026
View reviewed changes

Comment threadpygmt/src/grdview.py Outdated
Comment threadpygmt/src/_common.py Outdated

seisman reviewed Feb 4, 2026
View reviewed changes

Comment threadpygmt/src/_common.py Outdated

Xingchen Heand others added 3 commits February 4, 2026 17:36

Update pygmt/src/grdview.py
7d9bd89
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

Update pygmt/src/_common.py
fc029ad
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

Update pygmt/src/_common.py
47f3e1e
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

seisman approved these changes Feb 4, 2026
View reviewed changes

seisman added maintenance Boring but important stuff for the core devs final review call This PR requires final review and approval from a second reviewer labels Feb 4, 2026

seisman added this to the 0.19.0 milestone Feb 4, 2026

seisman self-requested a review February 4, 2026 09:43

update alias
11991fe

seisman removed the final review call This PR requires final review and approval from a second reviewer label Feb 4, 2026

seisman reviewed Feb 4, 2026
View reviewed changes

Comment threadpygmt/alias.py Outdated

Chuan1937 added 2 commits February 4, 2026 19:26

simplify the error message
3fef364

update the error message
350f67d

seisman reviewed Feb 5, 2026
View reviewed changes

Comment threadpygmt/exceptions.py Outdated
Comment threadpygmt/alias.py

Xingchen Heand others added 4 commits February 5, 2026 11:24

Update pygmt/exceptions.py
e4f040f
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

Replace long-form parameter(s) with short-form parameter(s)
f73fcdb

Merge branch 'feature/conflict' of github.com:Chuan1937/pygmt into fe…
1ed8e05
…ature/conflict

Merge branch 'main' into feature/conflict
5a5b87d

seisman reviewed Feb 6, 2026
View reviewed changes

Comment threadpygmt/alias.py Outdated

Update pygmt/alias.py
6e951b3
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

seisman reviewed Feb 6, 2026
View reviewed changes

Comment threadpygmt/alias.py Outdated

Update pygmt/alias.py
c3bf105
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

seisman reviewed Feb 6, 2026
View reviewed changes

Comment threadpygmt/alias.py

Update pygmt/alias.py
28e0582
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

seisman reviewed Feb 6, 2026
View reviewed changes

Comment threadpygmt/tests/test_alias_system.py

seisman reviewed Feb 6, 2026
View reviewed changes

Comment threadpygmt/tests/test_alias_system.py Outdated

Chuan1937 added 2 commits February 6, 2026 12:08

update test_alias_system.py
e33a11a

fix test
3743e11

seisman reviewed Feb 6, 2026
View reviewed changes

Comment threadpygmt/alias.py

Update pygmt/alias.py
f2194bf
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

seisman reviewed Feb 6, 2026
View reviewed changes

Comment threadpygmt/alias.py Outdated
Comment threadpygmt/exceptions.py Outdated
Comment threadpygmt/exceptions.py Outdated
Comment threadpygmt/src/_common.py Outdated
Comment threadpygmt/src/grdview.py Outdated

Xingchen Heand others added 6 commits February 6, 2026 16:27

Update pygmt/alias.py
3a73381
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

Update pygmt/exceptions.py
ff0c829
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

Update pygmt/exceptions.py
389161c
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

Update pygmt/src/_common.py
5cbfba4
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

Update pygmt/src/grdview.py
9737971
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

Merge branch 'main' into feature/conflict
e6dcc7c

seisman reviewed Feb 6, 2026
View reviewed changes

Comment threadpygmt/exceptions.py Outdated

Update pygmt/exceptions.py
b5ca451
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

seisman reviewed Feb 6, 2026
View reviewed changes

Comment threadpygmt/exceptions.py Outdated
Comment threadpygmt/exceptions.py Outdated

Xingchen Heand others added 2 commits February 6, 2026 16:41

Update pygmt/exceptions.py
983caf3
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

Update pygmt/exceptions.py
dffbc3f
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

seisman merged commit c5743fd into GenericMappingTools:mainFeb 6, 2026
15 of 20 checks passed

Chuan1937 deleted the feature/conflict branch February 6, 2026 08:53

This was referenced Feb 6, 2026
pygmt.grdgradient: Raise GMTParameterError when conflicting parameters are given #4391
Merged
Add new exceptions for invalid inputs and deprecate GMTInvalidInput exception #3707
Open

Uh oh!

Conversation

Chuan1937 commented Feb 4, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

seisman commented Feb 4, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

seisman commented Feb 6, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Chuan1937 commented Feb 6, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Chuan1937 commented Feb 4, 2026•
edited
Loading