Skip to content

Figure.pygmtlogo: Set the region based on wordmark for easier design - #4634

Merged
seisman merged 8 commits into
pygmtlogofrom
pygmtlogo-wordmark-design
May 12, 2026
Merged

Figure.pygmtlogo: Set the region based on wordmark for easier design#4634
seisman merged 8 commits into
pygmtlogofrom
pygmtlogo-wordmark-design

Conversation

@seisman

@seismanseisman commented May 11, 2026

Copy link
Copy Markdown
Member

Currently, the region is set to [-4, 4, -4, 4]. The issues are:

  1. We need to use no_clip=True when adding the wordmark
  2. We can't adding debugging lines (gridlines) for wordmarks, so we can't control the size of the wordmark accurately.

This PR does three things:

  • sets the region based on wordmark, i.e., larger x-range for horizontal wordmark and larger y-range for vertical wordmark
  • slightly modifies the code for adding debugging lines to ensure the debugging lines are plotted inside the visual logo only
  • adds two baseline images for the logo design with horizontal/vertical wordmark. The orginal baseline image for a visual logo without a wordmark is no longer needed, because it's already covered by the two new baseline images.

Ideally, we should be able to remove the no_clip=True argument from the Figure.text call. But as you can see, the wordmark in the vertical version is slightly wider than the visual logo.

Edit: I've slightly decreased the font size for the vertical wordmark, and then remove the no_clip parameter from Figure.text.

Old versionNew version
imageimage

Please note that the design of wordmarks is still ongoing in PR #4627. So, this PR focuses on adding tests to make the wordmark design easier.

@github-actions

github-actionsBot commented May 11, 2026

Copy link
Copy Markdown
Contributor

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

StatusPath
addedpygmt/tests/baseline/test_pygmtlogo_circle_design_horizontal.png
addedpygmt/tests/baseline/test_pygmtlogo_circle_design_vertical.png
deletedpygmt/tests/baseline/test_pygmtlogo_circle_design.png

Image diff(s)

Details

Added images

  • test_pygmtlogo_circle_design_horizontal.png

  • test_pygmtlogo_circle_design_vertical.png

Modified images

PathOldNew

Report last updated at commit a076530

@seismanseisman added the maintenance Boring but important stuff for the core devs label May 11, 2026
@seismanseisman added this to the 0.19.0 milestone May 11, 2026
@seismanseisman added the needs review This PR has higher priority and needs review. label May 11, 2026
Comment threadpygmt/src/pygmtlogo.py Outdated
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
Comment threadpygmt/src/pygmtlogo.py Outdated
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
@seisman
seisman merged commit 71f66dd into pygmtlogoMay 12, 2026
20 of 29 checks passed
@seisman
seisman deleted the pygmtlogo-wordmark-design branch May 12, 2026 13:36
@seismanseisman removed the needs review This PR has higher priority and needs review. label Jun 26, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenanceBoring but important stuff for the core devs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@seisman@yvonnefroehlich