Uh oh!
There was an error while loading. Please reload this page.
Figure.pygmtlogo: Increase the gap around the vertical red line and arrow - #4635
Merged
Conversation
seismanforce-pushed
the
pygmtlogo-gap-thickness
branch
from
May 11, 2026 09:03
560cfdb to
03bfd84CompareContributor
Summary of changed imagesThis is an auto-generated report of images that have changed on the DVC remote
Image diff(s)DetailsAdded imagesModified images
Report last updated at commit 126b3de |
seismanforce-pushed
the
pygmtlogo-gap-thickness
branch
from
May 11, 2026 09:13
03bfd84 to
126b3deCompareseisman
commented
May 11, 2026
| mask = np.abs(t_x) <= (thick_gap + r4) / 2 | ||
| return {"x": t_x[mask], "y": t_y[mask]} | ||
| def _vline_coords(): |
MemberAuthor
There was a problem hiding this comment.
I moved _vline_coords after _letter_t_coords, because the red vertical line at the top is more related to the letter T.
| # x0, y0 is the same as in _letter_t_coords(). | ||
| x0 = thick_gt / 2 | ||
| y0 = 1.8 * x0 * np.sqrt(3) | ||
| # The background arrow is thick_comp wider than the letter T. |
MemberAuthor
There was a problem hiding this comment.
Replace thick_comp with thick_gap.
yvonnefroehlich
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the gap between the vertical red line and the outline shape is set to
thick_comp / 2, i.e., half the thickness of the compass line. This value was chosen arbitrarily.This PR changes the gap from
thick_comp / 2tothick_gap, making it consistent with the gap between the letters G and M. The new gap is slightly larger, making it more visible when logos are small.After this change, the variable
thick_compis used only for the compass lines.