Skip to content

Figure.pygmtlogo: Remove the additional black outline for the black-and-white dark-theme logo - #4638

Merged
seisman merged 2 commits into
pygmtlogofrom
pygmtlogo-dark-blackwhite
May 13, 2026
Merged

Figure.pygmtlogo: Remove the additional black outline for the black-and-white dark-theme logo#4638
seisman merged 2 commits into
pygmtlogofrom
pygmtlogo-dark-blackwhite

Conversation

@seisman

Copy link
Copy Markdown
Member

Currently, we add an additional black outline to the black-and-white logo in dark theme. But is it really necessary? Dark mode usually implies a dark (black) background, and the white shape outline is already visually distinct from the background (see below).

importpygmtfrompygmt.paramsimportFramefig=pygmt.Figure()
fig.basemap(region=[-2, 2, -2, 2], projection="X4c", frame=Frame(fill="darkgray"))
fig.pygmtlogo(color=False, theme="dark", width="3c")
fig.show()
With black outlineWithout black outline
logo-darklogo-dark

@yvonnefroehlich

Copy link
Copy Markdown
Member

The outline is nice from a visual perspective, but from a consistency perspective, I prefer to remove this outline. I never really liked it, because it affects the size of the logo or the thickness of the surrounding shape.

@seismanseisman changed the title POC + WIP: Is the black outline really needed for black/white dark-theme logo?Figure.pygmtlogo: Remove the additional black outline for the black-and-white dark-theme logoMay 13, 2026
@seisman
seisman marked this pull request as ready for review May 13, 2026 11:10
@seismanseisman added the maintenance Boring but important stuff for the core devs label May 13, 2026
@seismanseisman added this to the 0.19.0 milestone May 13, 2026
@seisman

Copy link
Copy Markdown
MemberAuthor

I've remove the black outline, and also updated the baseline image with a gray background.

@github-actions

Copy link
Copy Markdown
Contributor

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

StatusPath
modifiedpygmt/tests/baseline/test_pygmtlogo_circle_no_wordmark.png

Image diff(s)

Details

Added images

Modified images

PathOldNew
test_pygmtlogo_circle_no_wordmark.png

Report last updated at commit ad98a38

@seisman
seisman merged commit 1ea6e8e into pygmtlogoMay 13, 2026
21 of 35 checks passed
@seisman
seisman deleted the pygmtlogo-dark-blackwhite branch May 13, 2026 23:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenanceBoring but important stuff for the core devs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@seisman@yvonnefroehlich