Skip to content

Figure.pygmtlogo: Parameterize existing tests - #4639

Merged
seisman merged 3 commits into
pygmtlogofrom
pygmtlogo-parameterize
May 14, 2026
Merged

Figure.pygmtlogo: Parameterize existing tests#4639
seisman merged 3 commits into
pygmtlogofrom
pygmtlogo-parameterize

Conversation

@seisman

Copy link
Copy Markdown
Member

No code changes, but parameterize existing tests so tests can share similar code.

We have 24 logos for different values of shape/theme/color/wordmark. After parameterization, we will have four tests:

@seismanseisman added this to the 0.19.0 milestone May 14, 2026
@seismanseisman added maintenance Boring but important stuff for the core devs needs review This PR has higher priority and needs review. labels May 14, 2026
@github-actions

github-actionsBot commented May 14, 2026

Copy link
Copy Markdown
Contributor

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

StatusPath
addedpygmt/tests/baseline/test_pygmtlogo_design_circle-horizontal.png
addedpygmt/tests/baseline/test_pygmtlogo_design_circle-vertical.png
deletedpygmt/tests/baseline/test_pygmtlogo_circle_design_horizontal.png
deletedpygmt/tests/baseline/test_pygmtlogo_circle_design_vertical.png
renamedpygmt/tests/baseline/test_pygmtlogo_circle_no_wordmark.png -> pygmt/tests/baseline/test_pygmtlogo_wordmark_none_circle.png

Image diff(s)

Details

Added images

  • test_pygmtlogo_design_circle-horizontal.png

  • test_pygmtlogo_design_circle-vertical.png

Modified images

PathOldNew

Report last updated at commit b4e1e38

@seismanseisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels May 14, 2026
@seisman
seisman merged commit 4f09ba6 into pygmtlogoMay 14, 2026
18 of 20 checks passed
@seisman
seisman deleted the pygmtlogo-parameterize branch May 14, 2026 10:26
@seismanseisman removed the final review call This PR requires final review and approval from a second reviewer label May 14, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenanceBoring but important stuff for the core devs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@seisman@yvonnefroehlich